Error float>int conversion after update to version 2.0.3

Deprecated function: Implicit conversion from float 403.19999999999993 to int loses precision in Drupal\image_captcha\Service\ImageCaptchaRenderService->generateImage() (line 103 of modules/contrib/captcha/modules/image_captcha/src/Service/ImageCaptchaRenderService.php). Drupal\image_captcha\Service\ImageCaptchaRenderService->generateImage('T88') (Line: 123) Drupal\image_captcha\Controller\CaptchaImageGeneratorController->image(Object) call_user_func_array(Array, Array) (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 583) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 166) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 191) Drupal\page_cache\StackMiddleware\PageCache->fetch(Object, 1, 1) (Line: 128) Drupal\page_cache\StackMiddleware\PageCache->lookup(Object, 1, 1) (Line: 82) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704) Drupal\Core\DrupalKernel->handle(Object) (Line: 19) Deprecated function: Implicit conversion from float 403.19999999999993 to int loses precision in Drupal\image_captcha\Service\ImageCaptchaRenderService->generateImage() (line 116 of modules/contrib/captcha/modules/image_captcha/src/Service/ImageCaptchaRenderService.php). Drupal\image_captcha\Service\ImageCaptchaRenderService->generateImage('T88') (Line: 123) Drupal\image_captcha\Controller\CaptchaImageGeneratorController->image(Object) call_user_func_array(Array, Array) (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 583) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 166) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 191) Drupal\page_cache\StackMiddleware\PageCache->fetch(Object, 1, 1) (Line: 128) Drupal\page_cache\StackMiddleware\PageCache->lookup(Object, 1, 1) (Line: 82) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704) Drupal\Core\DrupalKernel->handle(Object) (Line: 19) Deprecated function: Implicit conversion from float 403.19999999999993 to int loses precision in Drupal\image_captcha\Service\ImageCaptchaRenderService->generateImage() (line 149 of modules/contrib/captcha/modules/image_captcha/src/Service/ImageCaptchaRenderService.php). Drupal\image_captcha\Service\ImageCaptchaRenderService->generateImage('T88') (Line: 123) Drupal\image_captcha\Controller\CaptchaImageGeneratorController->image(Object) call_user_func_array(Array, Array) (Line: 123) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 583) Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97) Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 166) Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74) Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58) Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 191) Drupal\page_cache\StackMiddleware\PageCache->fetch(Object, 1, 1) (Line: 128) Drupal\page_cache\StackMiddleware\PageCache->lookup(Object, 1, 1) (Line: 82) Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704) Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comments & Activities

Issue created by @jjgw
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
@jjgw thank you - in this case I believe it wasn't really the update, but the PHP version or any other specific criteria in your case, but we'll take a look.

Any code-wise ideas already? Are you planning to create a MR to fix it?
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
44 pass
@anybody opened merge request.
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
@jjgw I prepared a MR, could you try the patch please and tell us, if it fixes the issue?
https://git.drupalcode.org/project/captcha/-/merge_requests/78.diff
Status changed to Needs review over 1 year ago1:34pm 20 July 2023
Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
Comment over 1 year ago →
🇺🇸United States japerry KVUO
Yup, that is exactly the same patch I came up with.. however, we may want to search to see if there are any other places floats are being implicitly cast to an int. This might be difficult to find except at runtime.
Comment over 1 year ago →
🇺🇸United States japerry KVUO
Also, note: this issue was occurring in earlier versions as well, but because it was in the streamresponse at the end of the response, it wasn't getting properly logged.
Comment over 1 year ago →
🇧🇪Belgium jjgw
I had already added following on line 102 in ImageCaptchaRenderService.php
$width = (int) round(($width), 0);
$height = (int) round(($height), 0);
but your patch is working at an earlier stage and is working well.
Thanks for the quick response.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
44 pass
Comment over 1 year ago →
System Message

japerry → committed 27c48f2f on 2.x authored by Anybody →
Issue #3375835 by Anybody: Error float>int conversion after update to...
Status changed to Fixed over 1 year ago3:52pm 25 July 2023
Comment over 1 year ago →
🇺🇸United States japerry KVUO
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Error float>int conversion after update to version 2.0.3

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities