Contrib.social

Lack of BC layer for a new 5th parameter to stage_file_proxy.fetch_manager service

Open on Drupal.org →
Created on 20 July 2023, almost 2 years ago
Updated 24 July 2023, almost 2 years ago

Problem/Motivation

Basically, version 2.1.0 has changed services signature (5th parameter has been added), but it is required (so no BC layer) leading to the following error during the update process:

ArgumentCountError: Too few arguments to function Drupal\stage_file_proxy\FetchManager::__construct(), 4 passed in ./core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 5 expected in Drupal\stage_file_proxy\FetchManager->__construct() (line 53 of ./modules/contrib/stage_file_proxy/src/FetchManager.php)

Steps to reproduce

Seems like this affects certain projects, probably depending on how the container was built and what services it has.

  • Update the module via composer
  • Run drush cr

Proposed resolution

Make it NULLable for now, aadd a BC layer, remove it in 3.0.0

Remaining tasks

Implement the above

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Fixed

Version

2.1

Component

Code

Created by

🇺🇦Ukraine Taran2L Lviv

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024