Errors found when running drupal-check. I found the errors on my custom folder cause I extended the IconsetBase class. So, I decided to run a report on the contrib module
1. Install drupal-check as per https://github.com/mglaman/drupal-check
2. Run drupal-check: php vendor/bin/drupal-check web/modules/contrib/social_media_links
------ -----------------------------------------------------------------------------------------------------
Line modules/social_media_links_field/src/Plugin/Field/FieldType/SocialMediaLinksFieldItem.php
------ -----------------------------------------------------------------------------------------------------
161 Access to an undefined property
Drupal\social_media_links_field\Plugin\Field\FieldType\SocialMediaLinksFieldItem::$platform.
💡 Learn more:
https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
162 Access to an undefined property
Drupal\social_media_links_field\Plugin\Field\FieldType\SocialMediaLinksFieldItem::$value.
💡 Learn more:
https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
163 Access to an undefined property
Drupal\social_media_links_field\Plugin\Field\FieldType\SocialMediaLinksFieldItem::$platform_values.
💡 Learn more:
https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
------ -----------------------------------------------------------------------------------------------------
------ ------------------------------------------------------------------------------------------------------
Line modules/social_media_links_field/src/Plugin/Field/FieldWidget/SocialMediaLinksFieldDefaultWidget.php
------ ------------------------------------------------------------------------------------------------------
26 Call to an undefined method
Drupal\Core\TypedData\TypedDataInterface::toArray().
------ ------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------------------------
Line modules/social_media_links_field/src/Plugin/Field/FieldWidget/SocialMediaLinksFieldSelectWidget.php
------ -----------------------------------------------------------------------------------------------------
27 Call to an undefined method
Drupal\Core\TypedData\TypedDataInterface::getEntity().
27 Call to an undefined method
Drupal\Core\TypedData\TypedDataInterface::toArray().
58 Access to an undefined property
Symfony\Component\Validator\ConstraintViolationInterface::$arrayPropertyPath.
💡 Learn more:
https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
58 Call to static method getValue() on an unknown class
Drupal\social_media_links_field\Plugin\Field\FieldWidget\NestedArray.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ -----------------------------------------------------------------------------------------------------
------ ---------------------------------------------
Line src/IconsetBase.php
------ ---------------------------------------------
118 Cannot call method getIconName() on string.
------ ---------------------------------------------
------ -----------------------------------------------------
Line src/Plugin/SocialMediaLinks/Iconset/FontAwesome.php
------ -----------------------------------------------------
47 Cannot call method getIconName() on string.
------ -----------------------------------------------------
[ERROR] Found 10 errors
Closed: won't fix
2.9
Code
It involves compliance with, or the content of coding standards. Requires broad community agreement.
Okay after further review, most of these issues are red herrings and nothing to worry about. If you ran drupal-check on some field formatters in core, you'd find similar issues.