- Issue created by @webfordreams
- Merge request !47Issue #3375080: Immediately publishing a node fails when no content type have content moderation enabled β (Merged) created by webfordreams
- last update
over 1 year ago 28 pass - Assigned to nginex
- Status changed to Needs work
over 1 year ago 7:32am 18 July 2023 - Status changed to Needs review
over 1 year ago 7:34am 18 July 2023 - last update
over 1 year ago PHPLint Failed - Issue was unassigned.
- Status changed to RTBC
over 1 year ago 7:49am 18 July 2023 - πΊπ¦Ukraine nginex
Updated patch a bit, the patch does the job, RTBC
- Status changed to Needs work
over 1 year ago 10:02am 18 July 2023 - π¬π§United Kingdom jonathan1055
Thanks for reporting this. Can you fix it for coding standards/linting, the test result of "PHPLint Failed" needs to be sorted before we can consider the change.
- Assigned to nginex
- πΊπ¦Ukraine nginex
I see, I used some features that are available since php 7.4, but this module should still support php 7.3 based on tests, ok, I will change it
- last update
over 1 year ago 28 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:08am 18 July 2023 - πΊπ¦Ukraine nginex
@jonathan1055,
Let's see if it works now for php 7.3 test
- last update
over 1 year ago 28 pass - last update
over 1 year ago 28 pass - last update
over 1 year ago 28 pass - First commit to issue fork.
- last update
7 months ago 49 pass, 2 fail - πΊπΈUnited States smustgrave
Rebased for 2.x since 8.x-1.x is no longer supported.
-
smustgrave β
committed 2196e080 on 2.x authored by
webfordreams β
Issue #3375080: Immediately publishing a node fails when no content type...
-
smustgrave β
committed 2196e080 on 2.x authored by
webfordreams β
- Status changed to Fixed
7 months ago 3:38pm 15 May 2024 - πΊπΈUnited States smustgrave
Going to merge as it does solve the issue. 2.x branch is currently broken so that's not showing correct info.
- Status changed to Active
7 months ago 7:38am 17 May 2024 - π¬π§United Kingdom jonathan1055
The fix added
$entity = $event->getNode();
but immediately after the new conditional check, we already had
$entity = $event->getEntity();
Is there a reason why we have to use
getNode()
? It seems wrong (a) to have both calls, and (b) it should be content-type generic, not just for nodes.Putting this back to 'active' to that it does not get 'closed (fixed)' after two weeks.