- Issue created by @LittleCoding
- 🇧🇩Bangladesh DSushmita Sylhet
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review. - 🇧🇩Bangladesh DSushmita Sylhet
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review. - 🇳🇱Netherlands kevin.brocatus
A quick run of
phpcs --standard=Drupal,DrupalPractice
seems to be all good!Looking through the code in detail I do not see any issues either. Only thing I found was an unnecessary blank line in the form() function in the OptionsGridWidget.php;
elseif ($property_selected === 'flex') { $field_widget_complete_form['#attributes']['data-flex-size'] = (int) $this->getSetting('size'); }
- Status changed to Needs work
over 1 year ago 9:50am 25 July 2023 - Status changed to Needs review
over 1 year ago 9:36pm 25 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
A single empty line that should be removed is not sufficient to change the status to Needs work. If there is anything else that should be changed, let us report that too.
- 🇨🇦Canada LittleCoding Hamilton, ON
The identified grammatical mistake and unneeded whitespace has been fixed. Changes can been found in 1.0.x-dev and will be part of the next minor release. Thank you @vinaymahale and @kevin.brocatus for flagging these.
- 🇨🇦Canada LittleCoding Hamilton, ON
Is there any more feedback or would someone else like to review?
- Status changed to RTBC
over 1 year ago 12:19pm 21 September 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
- Dries → ' post on Responsible maintainers
- Best practices for creating and maintaining projects →
- Maintaining a drupal.org project with Git →
- Commit messages - providing history and credit →
- Release naming conventions → .
- Helping maintainers in the issue queues →
You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank all the reviewers.
- Assigned to apaderno
- Status changed to Fixed
over 1 year ago 12:53pm 21 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.