Drupal 10 compatibility

CONTRIBUTED PROJECTS -------------------------------------------------------------------------------- Commerce User Points 9.0.1 Scanned on Thu, 07/13/2023 - 09:48. 2 warnings found. web/PHPStan failed: ┌──────────┬──────┬──────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼──────────────────────────────────────────────────────────────┤ │ Check │ 0 │ <h6>PHPStan command failed:</h6> <p>/usr/local/bin/php │ │ manually │ │ /app/vendor/bin/phpstan analyse --memory-limit=1500M │ │ │ │ --error-format=json │ │ │ │ --configuration=/tmp/upgrade_status/deprecation_testing.neon │ │ │ │ /app/web/modules/contrib/commerceuserpoints</p> <h6>Command │ │ │ │ output:</h6> <p>Empty.</p> <h6>Command error:</h6> <p>PHP │ │ │ │ Fatal error: Trait │ │ │ │ "Symfony\Bridge\PhpUnit\Legacy\PolyfillAssertTrait" not │ │ │ │ found in /app/web/sites/simpletest/Assert.php on line 92 │ │ │ │ Fatal error: Trait │ │ │ │ "Symfony\Bridge\PhpUnit\Legacy\PolyfillAssertTrait" not │ │ │ │ found in /app/web/sites/simpletest/Assert.php on line │ │ │ │ 92</p> │ │ │ │ │ └──────────┴──────┴──────────────────────────────────────────────────────────────┘ web/modules/contrib/commerceuserpoints/commerce_user_points.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^8.8.0 || ^9.0 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘

Comments & Activities

Issue created by @kaszarobert
Comment almost 2 years ago →
🇸🇰Slovakia kaszarobert
Comment almost 2 years ago →
🇸🇰Slovakia kaszarobert
First commit to issue fork.
Assigned to roshni27
Status changed to Needs work almost 2 years ago11:36am 13 July 2023
Comment almost 2 years ago →
🇮🇳India roshni27
Comment almost 2 years ago →
🇮🇳India roshni27
Comment almost 2 years ago →
🇮🇳India roshni27
@roshni27 opened merge request.
Issue was unassigned.
Status changed to Needs review almost 2 years ago12:53pm 13 July 2023
Comment almost 2 years ago →
🇮🇳India roshni27
please review MR.
First commit to issue fork.
Status changed to Needs work over 1 year ago2:13pm 3 November 2023
Comment over 1 year ago →
🇺🇸United States SocialNicheGuru
MR does not apply.
Comment over 1 year ago →
🇺🇸United States SocialNicheGuru
I can't get this to apply to 9.0.x-dev or 9.0.1.
Comment over 1 year ago →
🇺🇸United States SocialNicheGuru
Can someone check the MR to make sure that only necessary changes are included?
Comment about 1 year ago →
🇬🇷Greece user654
Any news on this for Drupal 10?
Comment about 1 year ago →
🇺🇸United States SocialNicheGuru
I can't get the MR to apply:

- Installing drupal/commerceuserpoints (9.0.1): Cloning 9.0.1 from cache
- Applying patches for drupal/commerceuserpoints
https://git.drupalcode.org/project/commerceuserpoints/-/merge_requests/8... (Drupal 10 compatibility - )
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/commerceuserpoints/-/merge_requests/8...
Status changed to Needs review 12 months ago2:08pm 13 May 2024
Comment 12 months ago →
🇮🇳India dev22.addweb
I have created a patch that adds Drupal 10 compatibility, fixes Drupal coding standards, and includes the composer.json file.
Status changed to Fixed 11 months ago1:46pm 30 May 2024
Comment 11 months ago →
🇮🇳India jigish.addweb
Added Drupal 10 support in 9.0.x dev branch, thanks for the help everyone.
Comment 11 months ago →
🇺🇸United States SocialNicheGuru
can the branch be published to the homepage. It does not look like there is anything available right now.
Status changed to Needs work 11 months ago9:54am 31 May 2024
Comment 11 months ago →
🇺🇸United States SocialNicheGuru
The updates are not reflected in the 9.0.x-dev#abc817c4.
This might be a packaging error.
Comment 11 months ago →
🇮🇳India jigish.addweb
Thanks @SocialNicheGuru for the review
We have released an alpha version to add Drupal 10 compatibility, which we have been working on for some time. You can see the changes in the new 3.0.x branch as well.
Commits:

https://git.drupalcode.org/project/commerceuserpoints/-/commit/69d06e27a...

https://git.drupalcode.org/project/commerceuserpoints/-/commit/abc817c49...

https://git.drupalcode.org/project/commerceuserpoints/-/commit/dc4a2de3a...
Status changed to Closed: outdated 10 months ago1:58pm 18 June 2024
Comment 10 months ago →
🇮🇳India jigish.addweb
Please open a new issue against 3.x if you still see these compatibility issues. Thanks

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities