custom.js dependencies are not set in commerce_user_points.libraries.yml

Hi, I have added required dependencies and solved the error called by once function in the custom.js.

Please review and verify.

Something is not right with that MR. If you open it, you'll see more than 9 commits and 40 changes. Are you sure you committed to the right branch? This issue now states 9.0.x-dev and the MR tries to merge things to 8.x-1.x

Hi @kaszarobert, ok will check on the branch and will push code to the right branch.

shubham_jain → closed merge request !9

Hi @kaszarobert, please review and verify.

@shubham_jain please read about this core change in Drupal 9.2: https://www.drupal.org/node/3158256 →

They write about that up until 9.2, there was no once() and core/once, there was just the $(' ... .').once() and core/jquery.once. So if you are changing that library and, that means the core_version_requirement should be ^9.2 minimum as the module's JS will break on those older Drupal versions with an undefined function error. And since Drupal 10 is not shipped with $(' ... .').once() and core/jquery.once, I would suggest to change the core_version_requirement, too. And since there is another problem with other deprecated things in this module, we can't add Drupal 10 compatibility to core_version_requirement until this is done: 📌 Drupal 10 compatibility Needs review

Hi everyone, I have updated the PR according to the comment #10. Please review it.

Added the dependencies in 3.0.x branch and we have removed the use on Once(). Thanks for the help.

Automatically closed - issue fixed for 2 weeks with no activity.