Improving media type management

One potential nuance for #3. Could this embedded form be specifically for the settings that are not normal field settings? For example the embedded form could be more focused on allowed formats, min and max resolutions, etc. A link to the field settings could also be included.

Such as hiding label and description and if the field is required or not? Things that are usually hidden from end users when adding media

Right, maybe even the default value as well

Needs review?

Since the MR is in draft, assume it's still being worked on. Plus the proposed solution has number of ideas but not which is picked.

May be related 🐛 Remove source from media mappings Needs work as we are trying to fix a big issue with the source mapping part of the form.

mglaman → changed the visibility of the branch 11.x to hidden.

I got this almost working, but it does bleed in concepts of field_ui. However, the submit is broken due to the way field config forms changed in 📌 Combine field storage and field instance forms Fixed .

On submit it breaks due to the entity builder associated to the field config form:

$form['#entity_builders'][] = 'field_form_field_config_edit_form_entity_builder';

Even though it is processing the subform, the entity being passed to the callback is the media type.

I tried out proposed option 2:

In Media source configuration provide a button to open the field settings form in a dialog for in-context modification.

It's not great. Saving the form in the dialog refreshes the page, which can cause a loss of data.

I tried approach 3 a bit more and worked around 🐛 Entity form default ::afterBuild and ::processForm are not working correctly for subforms Needs work . But it breaks down due to there being multiple subforms.