Adjust the module to the Drupal / Drupal JS core CS standards

FILE: /var/www/html/web/modules/custom/spamspan/src/Form/SpamspanTestForm.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 24 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 90 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/spamspan/src/TwigExtension/SpamspanExtension.php --------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------- 31 | ERROR | Parameter $spamspan is not described in comment 36 | ERROR | Missing parameter name --------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/spamspan/src/SpamspanTrait.php ------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ------------------------------------------------------------------------------------------- 277 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment 281 | ERROR | [ ] Parameter tags must be defined first in a doc comment 328 | WARNING | [ ] Only string literals should be passed to t() where possible ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/spamspan/src/Plugin/Field/FieldFormatter/EmailSpamspanFormatter.php ------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface. 84 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/modules/custom/spamspan/src/Plugin/Filter/FilterSpamspan.php ------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------ 26 | WARNING | Line exceeds 80 characters; contains 81 characters ------------------------------------------------------------------------------------ FILE: /var/www/html/web/modules/custom/spamspan/spamspan.module -------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------- 12 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway --------------------------------------------------------------------------------------------------------------------------------

16:9 error Replace `'span.spamspan'` with `"span.spamspan"` prettier/prettier 16:40 warning Unexpected unnamed function func-names 18:15 error Replace `'span.o'` with `"span.o"` prettier/prettier 19:13 error Replace `'span.o',·this).replaceWith('.'` with `"span.o",·this).replaceWith("."` prettier/prettier 25:11 error Unexpected string concatenation prefer-template 25:13 error Replace `'span.u'` with `"span.u"` prettier/prettier 26:11 error Replace `'@'` with `"@"` prettier/prettier 27:13 error Replace `'span.d'` with `"span.d"` prettier/prettier 28:27 error Replace `''` with `""` prettier/prettier 31:23 error Replace `'mailto:'` with `"mailto:"` prettier/prettier 31:23 error Unexpected string concatenation prefer-template 32:15 error Replace `'span.h'` with `"span.h"` prettier/prettier 35:33 error Replace `'span.h'` with `"span.h"` prettier/prettier 37:40 error Replace `'$1'` with `"$1"` prettier/prettier 38:65 error Replace `·n.replace(/:·/,·'=')` with `⏎············n.replace(/:·/,·"=")⏎··········` prettier/prettier 40:47 error Replace `'&'` with `"&"` prettier/prettier 42:24 error Replace `'?'` with `"?"` prettier/prettier 42:24 error Unexpected string concatenation prefer-template 48:32 error Replace `'span.t'` with `"span.t"` prettier/prettier 50:71 error Replace `'$1'` with `"$1"` prettier/prettier 53:51 error Replace `emailPattern,·function(match)` with `⏎············emailPattern,⏎············function·(match)·` prettier/prettier 53:65 warning Unexpected unnamed function func-names 54:1 error Replace `············return·match.replace('at',·'@').replace('dot',·'.'` with `··············return·match.replace("at",·"@").replace("dot",·"."` prettier/prettier 55:11 error Replace `}` with `··}⏎··········` prettier/prettier 59:31 error Replace `'span.e'` with `"span.e"` prettier/prettier 60:20 error Replace `'<a></a>'` with `"<a></a>"` prettier/prettier 68:21 error Replace `'href'` with `"href"` prettier/prettier 69:21 error Unnecessary use of conditional expression for default assignment no-unneeded-ternary 70:25 error Replace `'spamspan'` with `"spamspan"` prettier/prettier

Comments & Activities

Issue created by @Grevil
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
28 pass
@grevil opened merge request.
Assigned to Grevil
Status changed to Needs work almost 2 years ago3:07pm 12 July 2023
Comment almost 2 years ago →
🇩🇪Germany Grevil
Note, that I also adjusted the schema for "'spamspan_form_default_displaytext", this could be seen as out of scope, the need to change this was discovered through

Only string literals should be passed to t() where possible

for:
$this->t($this->settings['spamspan_form_default_displaytext']);

And this is the only place, where it is displayed, meaning we want a translatable "text" instead!

I'll finish the rest tomorrow.
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
28 pass
Status changed to Needs review almost 2 years ago7:37am 13 July 2023
Comment almost 2 years ago →
🇩🇪Germany Grevil
Done, please review!
Comment almost 2 years ago →
🇩🇪Germany Grevil
Note, that I used "/core/.eslintrc.json" for the javascript linting.
Issue was unassigned.
Status changed to RTBC almost 2 years ago8:11am 13 July 2023
Comment almost 2 years ago →
🇩🇪Germany Anybody Porta Westfalica
Nice cleanup!
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
28 pass
Comment almost 2 years ago →
System Message

Anybody → committed 6da8238a on 3.x authored by Grevil →
Issue #3374156 by Grevil: Adjust the module to the Drupal / Drupal JS...
Status changed to Fixed almost 2 years ago8:11am 13 July 2023
Comment almost 2 years ago →
🇩🇪Germany Anybody Porta Westfalica
Comment almost 2 years ago →
System Message

Grevil → committed f051bd3a on 3.x
Schema adjustments related to changes done in #3374156
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Adjust the module to the Drupal / Drupal JS core CS standards

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities