- Issue created by @urvashi_vora
- Status changed to Needs work
over 1 year ago 5:04am 13 July 2023 - 🇵🇭Philippines clarkssquared
Hi urvashi_vora
I applied your patch coding-standard-fixes.patch → to my local and I confirmed that your patch fixed the PHPCS issues. However, as I apply your patch I noticed that your patch has a whitespace error so I will move this to needs work and just kindly fix the whitespace error and this will be all good.
Please look at the screenshot I attached for your reference.
Thank you - 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi @clarkssquared,
I made the suggested changes, sending a Merge request right ahead.
Please review.Thanks
- Status changed to Needs review
over 1 year ago 5:55am 13 July 2023 - Status changed to RTBC
over 1 year ago 6:10am 13 July 2023 - 🇵🇭Philippines clarkssquared
Hi urvashi_vora
I applied your MR !1 to my local and I confirmed that it applies cleanly without errors and fixed all PHPCS issues.
Moving this to RTBC
Thank you
-
urvashi_vora →
authored 9649e822 on 1.0.x
Issue #3373823: Fix the issues reported by phpcs
-
urvashi_vora →
authored 9649e822 on 1.0.x
- Status changed to Fixed
about 1 year ago 9:32pm 22 November 2023 - 🇺🇸United States chrisolof
Looks great - thank you for your contribution! This has been merged into our 1.0.x branch and will be part of our next release.
Automatically closed - issue fixed for 2 weeks with no activity.