Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 11 July 2023, 12 months ago
Updated 23 May 2024, about 1 month ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/admin_ui_only/tests/src/Functional/AdminUiOnlyTest.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
25 | ERROR | The array declaration extends to column 87 (the limit is 80). The array
| | content should be split up over multiple lines
--------------------------------------------------------------------------------------

FILE: ...l/vb/d_cont/admin_ui_only/tests/src/FunctionalJavascript/ContextualLinksTest.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
57 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question
| | marks, colons, or closing parentheses
--------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/admin_ui_only/admin_ui_only.module
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
35 | ERROR | [ ] Missing parameter type
38 | ERROR | [x] Parameter comment must end with a full stop
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/admin_ui_only/src/Form/SettingsForm.php
--------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------
17 | ERROR | Missing short description in doc comment
116 | ERROR | The array declaration extends to column 146 (the limit is 80). The
| | array content should be split up over multiple lines
--------------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/admin_ui_only/src/EventSubscriber.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
47 | ERROR | Missing short description in doc comment
52 | ERROR | Missing short description in doc comment
----------------------------------------------------------------------

Time: 230ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig admin_ui_only/

Remaining tasks

Patch review

📌 Task
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to RTBC 12 months ago
  • Comment 12 months ago →
    🇵🇭Philippines kenyoOwen

    Hi urvashi_vora

    I applied the patch to the “Admin UI Only” module against Version 1.0.2 and confirmed that the errors are resolved. Please see the screenshots attached.

    Thank you.

  • Status changed to Closed: won't fix about 1 month ago
  • Comment about 1 month ago →
    🇬🇧United Kingdom alexpott 🇪🇺🌍

    The project has the following issue template:

    Issues welcome! We like contributions of all sorts.

    A note issues generated from the output of automated scanners
    This project uses Drupal core's core/phpcs.xml.dist to check coding standards. If you file a coding standards, ensure that running vendor/bin/phpcs -ps --standard="core/phpcs.xml.dist" modules/admin_ui_only/ fails. Or, alternatively, if a more strict automated scanner finds a real bug, submit an issue to fix that bug and not the rest of the changes the automated scanner finds. Thank you for your contributions.

  • Comment about 1 month ago →
    🇬🇧United Kingdom alexpott 🇪🇺🌍

    Also the project has moved to gitlab and PHPCS is checked as part of that and we are green (using Drupal core's rules) - see 📌 Move to gitlab Fixed

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024