Fix the issues reported by phpcs

Created on 11 July 2023, over 1 year ago

Updated 24 May 2024, 8 months ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/vcp4dates/src/Plugin/views/cache/DateFilter.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
29 | ERROR | [ ] Parameter $configuration is not described in comment
29 | ERROR | [ ] Parameter $plugin_id is not described in comment
29 | ERROR | [ ] Parameter $plugin_definition is not described in comment
35 | ERROR | [ ] Unknown type hint "TimeInterface" found for $time
68 | ERROR | [ ] The array declaration extends to column 107 (the limit is
| | 80). The array content should be split up over multiple
| | lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/vcp4dates/vcp4dates.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------

Time: 103ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig vcp4dates/

Remaining tasks

Patch review

📌 Task

Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Comments & Activities

Issue created by @urvashi_vora
Comment over 1 year ago →
🇦🇺Australia darvanen Sydney, Australia
Hi, whilst I appreciate coding standards patches, my policy is not to give credit to contributors who already have credit for coding standards patches. Coding standards patches are great for folks finding their feet with the mechanics of contribution, but more experienced developers can help in other ways. Please refer to tip 2 on https://www.previousnext.com.au/blog/5-simple-tips-increase-your-drupal-... for more information.
Comment 10 months ago →
🇦🇺Australia darvanen Sydney, Australia
Status changed to RTBC 8 months ago9:05am 24 May 2024

Comment 8 months ago →

a.aaronjake

Hi @darvanen,

Applied the patch above and found all issues were fixed.

contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig vcp4dates/
➜  contrib git:(main) ✗

Thank you.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024