Contrib.social

Remove duplicate detected key for impressedCard

Open on Drupal.org →
Created on 10 July 2023, over 1 year ago
Updated 10 September 2023, over 1 year ago

Problem/Motivation

invalid data type in config core.entity_view_display.block_content.varbase_impressed_card_block.default, found in file modules/contrib/varbase_layout_builder/modules/varbase_impressed_card_block/config/optional/core.entity_view_display.block_content.
> varbase_impressed_card_block.default.yml: Duplicate key "impressedCard" detected at line 110 (near " image_position: top").

Proposed resolution

Removed duplicate detected key for impressedCard

Still needs more testing.
Planned to change all configs.
The module is in early alpha on the 10.1.x branch.

to change:

  • impressedCard to card_impressed or card-impressed following with new naming convention
  • image to media to manage any Drupal media
  • image_position to media_position to manage any Drupal media

Following with changes in Varbase Components →

Impressed Card
Impressed card component and pattern.
It contains a media element — typically an image — on the top with a headline and text on the bottom.
It is a versatile pattern that contain content such as blog posts, user information, and other content types.
https://git.drupalcode.org/project/varbase_components/-/blob/2.0.x/compo...

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 10.0.0-beta1 → , varbase_layout_builder-10.1.0-alpha6 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

🐛 Bug report
Status

Fixed

Version

10.1

Component

Code

Created by

🇯🇴Jordan ahmad abbad Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024