- Issue created by @urvashi_vora
I think this is a duplicate of
https://www.drupal.org/project/commerce_mercadopago/issues/3367764 📌 Improve the code Fixed- 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi, that issue seems to be fixed, but in the latest pull, I got these issues and thus I created a ticket here. So, in my opinion it is similar but not duplicate.
- First commit to issue fork.
- Status changed to Needs work
over 1 year ago 1:05am 14 August 2023 - 🇦🇷Argentina Zarpele
Hey @urvashi_vora The patch was not applied to the latest version. Could you reformulate it? Use the MR behavior instead of a patch for a better review.
- First commit to issue fork.
- @thakurnishant_06 opened merge request.
- 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi @thakurnishant_06, I was supposed to work on this as @Zarpele requested to me, however, it is good that you created an MR, but please try to wait for the supposed assignee for working on the tickets.
Also. @Zarpele, I am updating the issue summary with the recent execution output of phpcs.
- 🇮🇳India urvashi_vora Madhya Pradesh, India
Also, I reviewed the MR and it fixes all PHPCS issues as per updated issue summary, except the one issue:
FILE: ...rce_mercadopago-3373628/src/Plugin/Commerce/PaymentGateway/MercadoPago.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
151 | ERROR | The $_GET super global must not be accessed directly; inject the
| | request.stack service and use $stack->getCurrentRequest()->query
| | instead
--------------------------------------------------------------------------------Time: 122ms; Memory: 10MB
Adding the same in remaining tasks section.
- Status changed to Needs review
over 1 year ago 10:53am 14 August 2023 - 🇮🇳India urvashi_vora Madhya Pradesh, India
Fixed last issue as well. Please review.
- Status changed to RTBC
over 1 year ago 9:02pm 22 August 2023 - 🇦🇷Argentina Zarpele
The code makes sense to me and I do not have any phpcs issues anymore.
After testing it, I solved an issue on service name introduced here https://git.drupalcode.org/project/commerce_mercadopago/-/merge_requests...
RTBC +1