- Issue created by @hodba
- Status changed to Needs review
over 1 year ago 7:33am 10 July 2023 - 🇮🇳India vishal.kadam Mumbai
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- Status changed to Needs work
over 1 year ago 8:03am 10 July 2023 - 🇮🇳India vishal.kadam Mumbai
1. FILE: stripe_webform_payment.services.yml
# stripe_webform_payment.event_subscriber: # class: Drupal\stripe_webform_payment\EventSubscriber\StripeWebformPaymentSubscriber # arguments: ['@messenger'] # tags: # - { name: event_subscriber }
Remove commented code.
2. FILE: stripe_webform_payment.module
use Drupal\Core\Cache\CacheBackendInterface;
Place the use statement as the top.
3. FILE: stripe_webform_payment.info.yml
# Information added by Drupal.org packaging script on 2023-04-30 version: '1.0.0-beta1' project: 'stripe_webform_payment' datestamp: 1682838410
Remove these lines. It will be added automatically by the packaging script.
- Status changed to Needs review
over 1 year ago 8:27am 10 July 2023 - 🇸🇾Syria hodba Dubai
Thak you vishal.kadam
The code is updated as instructed. - 🇮🇳India vishal.kadam Mumbai
Rest looks fine to me.
Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.
- 🇸🇾Syria hodba Dubai
In order to speed up the process, I created a dummy account on Stripe that can be used to test the module faster:
Publishable key: pk_test_51J7tbHL9kB28upArnW0kNF4GotNU0Yu6Ox6NotfCmVSgwDbxfGUF7rHI5HdGNsem6hiGPkwcWmxaP4DjFuNLuRHv00H5W8L1xySecret key: sk_test_51J7tbHL9kB28upAriUrtKYnf6j8LCuyTNr1gnc77NXeHlhH4ETaCKflNlyVFEQeJ8MBUO2A73jwwW2hX4swdE0BX00uMgn9bjF
Please make sure to use them in the test keys section. These keys are created as a dummy and have no effect on the account and will be deleted after the verification is completed.
Hope to hear from you soon :)
- 🇮🇳India vinaymahale
I am changing priority as per Issue priorities.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
- Dries → ' post on Responsible maintainers
- Best practices for creating and maintaining projects →
- Maintaining a drupal.org project with Git →
- Commit messages - providing history and credit →
- Release naming conventions → .
- Helping maintainers in the issue queues →
You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank all the reviewers.
- Assigned to apaderno
- Status changed to Fixed
over 1 year ago 1:03pm 27 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.