Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org ā†’
Created on 7 July 2023, over 1 year ago
Updated 31 May 2024, 7 months ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/search_api_pinecone/search_api_pinecone.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
65 | WARNING | #options values usually have to run through t() for translation
66 | WARNING | #options values usually have to run through t() for translation
67 | WARNING | #options values usually have to run through t() for translation
--------------------------------------------------------------------------------

FILE: ...ch_api_pinecone/src/Plugin/search_api/backend/SearchApiPineconeBackend.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------
266 | WARNING | Unused variable $pinecode_client.
280 | WARNING | Unused variable $pinecode_client.
--------------------------------------------------------------------------------

Time: 108ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig search_api_pinecone/

Remaining tasks

Patch review

šŸ“Œ Task
Status

RTBC

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • First commit to issue fork.
  • @frederikvho opened merge request.
  • Comment over 1 year ago ā†’
    šŸ‡§šŸ‡ŖBelgium Frederikvho Belgium

    Hi,

    I applied the patch from the issue summary and ran PHPCS again but still received some errors/warnings.

    I created a fork, applied the patch there, applied fixes from PHPCBF and applied some additional manual fixes like removing unused variables.
    Please review: MR 1

    Kind regards

  • Status changed to Needs work 7 months ago
  • Comment 7 months ago ā†’
    a.aaronjake

    Hi @Frederikvho,

    Applied MR!1 successfully and it fixed all issues.

    search_api_pinecone-search_api_pinecone git:(1.0.x) curl https://git.drupalcode.org/project/search_api_pinecone/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6342    0  6342    0     0  13329      0 --:--:-- --:--:-- --:--:-- 13580
patching file search_api_pinecone.module
patching file src/Plugin/search_api/backend/SearchApiPineconeBackend.php
āžœ  search_api_pinecone-search_api_pinecone git:(1.0.x) āœ— cd ..
āžœ  contrib git:(main) āœ— phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig search_api_pinecone-search_api_pinecone
āžœ  contrib git:(main) āœ—

    Will move this to RTBC.

    Thanks,
    Jake

  • Status changed to RTBC 7 months ago
  • Comment 7 months ago ā†’
    šŸ‡®šŸ‡³India manish-31

    I have also confirmed the MR resolves all the PHPCS warnings.

    RTBC +1

    Updating ticket status from NW to RTBC.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024