- Issue created by @urvashi_vora
- Status changed to RTBC
10 months ago 11:13am 16 January 2024 - 🇮🇳India Ashutosh Ahirwal India
Provided Patch get applied cleanly and does not throw any error.
Moving to RTBC
FILE: /var/www/html/vb/d_cont/tarte_au_citron_linkedininsighttag/README.txt
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------
37 | WARNING | Line exceeds 80 characters; contains 106 characters
39 | WARNING | Line exceeds 80 characters; contains 103 characters
---------------------------------------------------------------------------
FILE: ...itron_linkedininsighttag/src/Plugin/tarte_au_citron/Linkedininsighttag.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
29 | ERROR | [x] Expected 1 blank line before function; 2 found
31 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
32 | ERROR | [x] Array closing indentation error, expected 4 spaces but found
| | 6
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...rte_au_citron_linkedininsighttag/tarte_au_citron_linkedininsighttag.module
--------------------------------------------------------------------------------
FOUND 16 ERRORS AND 5 WARNINGS AFFECTING 14 LINES
--------------------------------------------------------------------------------
6 | ERROR | [x] There must be exactly one blank line after the file comment
10 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
10 | ERROR | [x] No space found before comment text; expected "// function
| | tarte_au_citron_linkedininsighttag_page_attachments_alter(array
| | &$attachments) {" but found "//function
| | tarte_au_citron_linkedininsighttag_page_attachments_alter(array
| | &$attachments) {"
10 | ERROR | [x] Inline comments must start with a capital letter
10 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
11 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
11 | ERROR | [ ] Missing short description in doc comment
12 | WARNING | [x] The variable name should be defined after the type
15 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
16 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
16 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
17 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
20 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
20 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
21 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters
21 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
23 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
25 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 82ms; Memory: 8MB
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig tarte_au_citron_linkedininsighttag/
Patch review
1.0
Code
It involves compliance with, or the content of coding standards. Requires broad community agreement.
Provided Patch get applied cleanly and does not throw any error.
Moving to RTBC