- Issue created by @berdir
- 🇫🇮Finland lauriii Finland
It looks like this is caused by
\Drupal\Core\Form\FormSubmitter::redirectForm
which is using current request and$request->query->all()
to generate URL to redirect to. I'm not sure what would be the best way to address the bug here. We could define a redirect URL for this form, but I think we should try to find a more generic solution 🤔 - Status changed to Needs review
over 1 year ago 7:24pm 6 July 2023 - last update
over 1 year ago 29,802 pass - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - 🇫🇮Finland lauriii Finland
Worked on some tests for this and realized that we'll need to do something about
\Drupal\Core\Routing\RedirectDestination
too. This is starting to be in quite a few places so I'm wondering if we should try to get rid of the query params from the request in the request stack. - last update
over 1 year ago 29,802 pass, 2 fail - last update
over 1 year ago 29,803 pass - last update
over 1 year ago 29,803 pass The last submitted patch, 7: 3372678-7-test-only.patch, failed testing. View results →
- Status changed to RTBC
over 1 year ago 8:08pm 7 July 2023 - 🇨🇭Switzerland berdir Switzerland
Works fine for me. Having to handle this all over the place isn't nice, but we have better and better test coverage of this stuff, so hopefully we can refactor it into something better eventually.
- last update
over 1 year ago 29,803 pass - Status changed to Fixed
over 1 year ago 12:12pm 10 July 2023 - 🇬🇧United Kingdom catch
📌 Compress ajax_page_state Fixed doesn't remove this from the query params yet but it could, and the extra test coverage will definitely help that issue to not break even more things.
Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.