- Issue created by @phenaproxima
- last update
over 1 year ago Custom Commands Failed - @phenaproxima opened merge request.
- last update
over 1 year ago 498 pass, 105 fail - last update
over 1 year ago 682 pass, 55 fail - last update
over 1 year ago 295 pass, 133 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 742 pass, 24 fail - last update
over 1 year ago 801 pass, 5 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 810 pass, 2 fail - last update
over 1 year ago 811 pass - last update
over 1 year ago 811 pass - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 811 pass - last update
over 1 year ago 811 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 1:39pm 7 July 2023 - Assigned to phenaproxima
- Status changed to Needs work
over 1 year ago 4:14pm 7 July 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Wow, thanks for doing this. Just a few questions and suggestions
- last update
over 1 year ago 811 pass - Assigned to tedbow
- Status changed to Needs review
over 1 year ago 4:22pm 7 July 2023 - last update
over 1 year ago 811 pass - 🇺🇸United States phenaproxima Massachusetts
Tagging for a follow-up, most likely upstream, to figure out the upper-casing of ProcessOutputCallbackInterface's output types, compared to Symfony Process's casing.
- Assigned to traviscarden
- Status changed to RTBC
over 1 year ago 4:39pm 7 July 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
We need a follow-up to figure out why the string casing has changed in composer stager.
- Issue was unassigned.
- last update
over 1 year ago 811 pass -
phenaproxima →
committed 99a864a0 on 3.0.x
Issue #3372673 by phenaproxima, tedbow: Update Composer Stager to 2.0.0-...
-
phenaproxima →
committed 99a864a0 on 3.0.x
- Status changed to Needs review
over 1 year ago 5:14pm 7 July 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This looks like a magnificent clean-up! 🤩🤩🤩🤩
👏
- 🇺🇸United States traviscarden
Sorry, @tedbow, I didn't see your comment about the case of the "OUT"/"ERR" strings... I see what happened there. It had to do with a refactoring of Composer Stager's interface with Symfony Process. It exposes a weakness that I have a solution to, to make such regressions harder to commit: enums. I'll share the result when it's ready for you.
- Status changed to Fixed
over 1 year ago 6:02pm 12 July 2023 - 🇺🇸United States phenaproxima Massachusetts
Since @TravisCarden is now aware of this problem and fixing it upstream, I don't think we need a follow-up.
Automatically closed - issue fixed for 2 weeks with no activity.
