- Issue created by @heddn
- Status changed to Needs review
over 1 year ago 5:09pm 5 July 2023 - last update
over 1 year ago 22 pass, 2 fail The last submitted patch, 2: 3372643.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
over 1 year ago 36 pass - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago 36 pass - last update
over 1 year ago 36 pass - 🇳🇮Nicaragua dinarcon
Thanks for working on this!
I applied the patch and got the
migrate_tools
versions of the commands while using Druah 12. Per https://www.drush.org/12.x/commands/#attributes-or-annotations it says either PHP8 Attributes or Annotations are valid ways to declare a command. The current patch adds PHP8 Attributes on top of the existing Annotations. Shall we remove the latter?For the record, I tested removing the PHP8 Attributes and the commands indeed worked with just the annotations. I guess my questions is if
migrate_tools
should try to match the PHP requirements from the Drush versions that it supports. Per https://www.drush.org/12.x/install/#drupal-compatibility, Drush 12 requires PHP 8.1. If we keep the annotation version only, we can support Drush 11 and 12 at the same time without requiring PHP 8.1, right? - heddn Nicaragua
I ran a few more tests of various version combinations. I'll have to update the project page to list the supported version combinations. But Drush 11 and 12 and PHP 7.4/8+ all seem to work together. Drush 10 doesn't seem to be functional at this point, but that was EOL months ago. I think we're good to commit this.
- Status changed to Fixed
over 1 year ago 5:20pm 6 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 12:54pm 21 November 2023 - leymannx Berlin
The command is supposed to live inside
src/Drush/Commands/
. We should reopen and fix it. - leymannx Berlin
Opened follow-up issue: 📌 Move Drush commands from src/Drush/ to src/Drush/Commands/ Fixed .