Fixing the errors/warnings reported by Php_CodeSniffer

C:\xampp\htdocs\backendassignment\web\modules\contrib>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig redirect_after_logout FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\README.md ------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------- 52 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\redirect_after_logout.install --------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\redirect_after_logout.module -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 8 | WARNING | [x] Unused use statement 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\src\EventSubscriber\RedirectAfterLogoutSubscriber.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 6 LINES --------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 77 | ERROR | [ ] Parameter $configFactory is not described in comment 77 | ERROR | [ ] Parameter $currentUser is not described in comment 80 | ERROR | [ ] Missing parameter name 82 | ERROR | [ ] Missing parameter name 86 | ERROR | [x] Data types in @param tags need to be fully namespaced 156 | ERROR | [ ] Expected type hint "ResponseEvent"; found "RequestEvent" for $event --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\src\Form\RedirectLogoutSettings.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\tests\src\Functional\MasqueradeTest.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 29 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 66 | ERROR | [x] Expected 1 blank line after function; 0 found 67 | ERROR | [x] The closing brace for the class must have an empty line before it ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\tests\src\Functional\RedirectTest.php ----------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES ----------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 58 | ERROR | [x] There should be no white space after an opening "(" 60 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters 93 | WARNING | [x] A comma should follow the last multiline array item. Found: 'error' 106 | ERROR | [x] Expected 1 blank line after function; 0 found 107 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\tests\src\Functional\SettingsTest.php ----------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\tests\src\Functional\SettingsTokenTest.php ---------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ---------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\redirect_after_logout\tests\src\Functional\TestBase.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 3 WARNINGS AFFECTING 9 LINES ------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 128 | ERROR | [x] Parameter comment must end with a full stop 146 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 185 | ERROR | [ ] Doc comment for parameter $destination does not match actual variable name $given_destination 230 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters 232 | ERROR | [x] Expected "string|null" but found "string|NULL" for parameter type 233 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters 236 | ERROR | [ ] Parameter tags must be grouped together in a doc comment 240 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- Time: 2.09 secs; Memory: 6MB

Comments & Activities

Issue created by @sidharth_soman
@sidharth_soman opened merge request.
Issue was unassigned.
Status changed to Needs review almost 2 years ago1:44pm 5 July 2023
Comment almost 2 years ago →
🇮🇳India sidharth_soman Bangalore
I've fixed all the issues except for the 'line exceeds 80 characters' warning. Leaving that as it is for readability purposes.

Please review the MR
Comment over 1 year ago →
System Message

nevergone → committed dc57324c on 8.x-1.x authored by sidharth_soman →
Issue #3372569: Fixing the errors/warnings reported by Php_CodeSniffer
Status changed to Fixed over 1 year ago10:54pm 24 August 2023
Comment over 1 year ago →
🇭🇺Hungary nevergone Nyíregyháza, Hungary, Europe
Thanks!
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fixing the errors/warnings reported by Php_CodeSniffer

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities