Make compatible with domain 2.x

Created on 5 July 2023, over 1 year ago
Updated 15 September 2023, about 1 year ago

Problem/Motivation

This module is blocking use of domain 2.x due to version constraint in composer.json (which might be there for a good reason).

Steps to reproduce

Attempt to upgrade domain to 2.x on site with this module in composer.json:

- drupal/domain_menu_access is locked to version 2.0.0-alpha3 and an update of this package was not requested.
- drupal/domain_menu_access 2.0.0-alpha3 requires drupal/domain ^1 -> found drupal/domain[1.0.0-beta1, ..., 1.0.0-beta8] but it conflicts with your root composer.json require (^2.0@beta).

Proposed resolution

Initially just allow both 1.x and 2.x of domain, get it installed, then do some testing.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇵🇹Portugal dubois

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @dubois
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    1 pass
  • @dubois opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • 🇵🇹Portugal dubois

    Using the forked version requires a number of changes to composer.json:

    • Update repositories section to exclude getting releases of this module and add repo pointing to fork:
          "repositories": [
              {
                  "type": "composer",
                  "url": "https://packages.drupal.org/8",
                  "exclude": [
                      "drupal/domain_menu_access"
                  ]
              },
              {
                  "type": "git",
                  "url": "https://git.drupalcode.org/issue/domain_menu_access-3372512.git"
              }
          ],
    • Required the change dev branch:
      "drupal/domain_menu_access": "dev-3372512-make-compatible-with",

    Module works as expected with domain 2.0.0-beta1. This is a trivial change so suggest so hope we can get it merged soon.

  • Status changed to RTBC about 1 year ago
  • 🇧🇷Brazil bruno_lima

    +1 for #2 📌 Make compatible with domain 2.x Fixed

    Patch applies cleanly in current version (2.0.0-alpha3).

    Still had to manually update composer.lock to add '^2' in the dependency string in order to get domain updated to '2.0.0-beta1', since composer.lock is generated before patches are applied.

    Module works with domain version 2.x just fine, as expected.

    This is a very simple change, so let's get this merged!

    Cheers.

  • 🇧🇪Belgium tim-diels Belgium 🇧🇪

    Let me look to get this committed.

  • Status changed to Fixed about 1 year ago
  • 🇧🇪Belgium tim-diels Belgium 🇧🇪

    Good work dubois!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024