- Issue created by @dubois
- last update
over 1 year ago 1 pass - @dubois opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:31am 6 July 2023 - 🇵🇹Portugal dubois
Using the forked version requires a number of changes to composer.json:
- Update repositories section to exclude getting releases of this module and add repo pointing to fork:
"repositories": [ { "type": "composer", "url": "https://packages.drupal.org/8", "exclude": [ "drupal/domain_menu_access" ] }, { "type": "git", "url": "https://git.drupalcode.org/issue/domain_menu_access-3372512.git" } ],
- Required the change dev branch:
"drupal/domain_menu_access": "dev-3372512-make-compatible-with",
Module works as expected with domain 2.0.0-beta1. This is a trivial change so suggest so hope we can get it merged soon.
- Update repositories section to exclude getting releases of this module and add repo pointing to fork:
- Status changed to RTBC
over 1 year ago 12:23am 6 September 2023 - 🇧🇷Brazil bruno_lima
+1 for #2 📌 Make compatible with domain 2.x Fixed
Patch applies cleanly in current version (2.0.0-alpha3).
Still had to manually update composer.lock to add '^2' in the dependency string in order to get domain → updated to '2.0.0-beta1', since composer.lock is generated before patches are applied.
Module works with domain version 2.x just fine, as expected.
This is a very simple change, so let's get this merged!
Cheers.
-
tim-diels →
committed c3204f4a on 2.0.x authored by
dubois →
Issue #3372512 by dubois, tim-diels: Make compatible with domain 2.x
-
tim-diels →
committed c3204f4a on 2.0.x authored by
dubois →
- Status changed to Fixed
over 1 year ago 11:14am 15 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.