Undeclared dependency on PHP 8.1

Open on Drupal.org →

Created on 4 July 2023, 12 months ago

Updated 31 October 2023, 8 months ago

During my testing of the module, error

PHP Parse error: syntax error, unexpected identifier "LayoutParagraphsLayoutTempstor...", expecting variable in /app/web/modules/contrib/mercury_editor/modules/mercury_editor_templates/src/Controller/InsertTemplateController.php on line 34

appeared during cache clear. A quick look in that file revealed that there are readonly properties used, even though the composer.json file doesn't declare dependency on PHP 8.1 (I'm using 8.0).

It's possible that there are more instances of these issues. It looks like https://github.com/symfony/polyfill-php81 won't help here, so perhaps there should be some rector-based transpiling happening during the development process?

🐛 Bug report

Status

Fixed

Version

2.1

Component

Code

Created by

🇨🇿Czech Republic milos.kroulik

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @milos.kroulik
Comment 10 months ago →
🇩🇪Germany Anybody Porta Westfalica
I think the module should just require PHP 8.1 - that's totally fine now.
Assigned to Mohd Sahzad
Comment 10 months ago →
🇮🇳India Mohd Sahzad
Issue was unassigned.
Comment 10 months ago →
🇮🇳India Mohd Sahzad
Hi @milos.kroulik,
needs more steps for reproduce this issue : Undeclared dependency on PHP 8.1
First commit to issue fork.
@justin2pin opened merge request.
Status changed to Fixed 8 months ago11:46am 31 October 2023
Comment 8 months ago →
🇺🇸United States justin2pin
Declared PHP 8.1 as a dependency in the module's composer.json file.
Comment 8 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024