- Issue created by @DamienMcKenna
- π«π·France prudloff Lille
If this requires a manual step to require the library, it should probably be considered a breaking change and done in a major release.
- π«π·France mably
AFAIK the library is included because it's slightly customized for use with Drupal.
So externalizing it using composer might not be a trivial task. Feasible though.
- π«π·France prudloff Lille
Here is the diff between this upstream version and the version in tacjs.
- π«π·France mably
Looks like the MIT license is GPL-2.0-or-later compatible:
https://www.drupal.org/node/1475972#gplv2-compatible-licenses β
Or am I missing something?Duplicating third-party assets is strongly discouraged though:
https://www.drupal.org/docs/develop/git/setting-up-git-for-drupal/drupal... β - Status changed to Closed: works as designed
over 1 year ago 2:16pm 5 July 2023 - πΊπΈUnited States DamienMcKenna NH, USA
Ok, fair; see also: https://www.drupal.org/about/licensing#gpl-compatible β
Especially when there are changes.
BTW it might be worth storing the changes as a patch in the repo, to make future update easier.
- Status changed to Needs work
over 1 year ago 7:48am 12 July 2023 - π«π·France prudloff Lille
I am reopening because, even if the license is OK, it is a bad practice to duplicate code like this.
Let's see if we can get the tacjs changes committed upstream: https://github.com/AmauriC/tarteaucitron.js/pull/1136
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Looks like the maintainer provided a workaround: https://github.com/AmauriC/tarteaucitron.js/pull/1136#issuecomment-16321...
I'd suggest going that route at least for now. This will help also with security issues reported upstream that might affect this module. Increasing prio because of that.