Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 3 July 2023, almost 2 years ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/webform_ban/webform_ban.module
---------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
---------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
18 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10
19 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
20 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
21 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
22 | ERROR | [x] Array indentation error, expected 12 spaces but found 10
28 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: ...cont/webform_ban/src/Plugin/Action/WebformSubmissionBanAndDeleteAction.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
21 | ERROR | [x] Expected 1 blank line before function; 0 found
34 | ERROR | [x] Expected 1 blank line after function; 0 found
35 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 91ms; Memory: 8MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig webform_ban/

Remaining tasks

Patch review

📌 Task
Status

RTBC

Version

1.1

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @urvashi_vora
  • Status changed to RTBC almost 2 years ago
  • Comment almost 2 years ago →
    🇵🇭Philippines roberttabigue

    Hi,

    I reviewed the changes and confirmed the Patch was applied cleanly.

    Checking patch src/Plugin/Action/WebformSubmissionBanAndDeleteAction.php...
Checking patch webform_ban.module...
Applied patch src/Plugin/Action/WebformSubmissionBanAndDeleteAction.php cleanly.
Applied patch webform_ban.module cleanly.

    All PHPCS errors have been fixed.

    I ran this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig webform_ban/

    Applied to Webform Ban module with 1.1.0 version and with the Drupal core version of 9.5.x.

    Please see the attached screenshots for your reference.

    I'm moving this now to RTBC.

    Thank you!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024