Contrib.social

Fix the issues reported by phpcs.

Open on Drupal.org ā†’
Created on 3 July 2023, over 1 year ago
Updated 15 August 2024, 3 months ago

Problem/Motivation

PHP Codesniffer gives errors/warnings upon being run on the module.

Steps to reproduce

Run the phpcs command on the module.

Given
When
Then

Proposed resolution

Remaining tasks

  • āœ… File an issue about this project
  • āœ… Addition/Change/Update/Fix to this project
  • āŒ Testing to ensure no regression
  • āŒ Automated unit/functional testing coverage
  • āŒ Developer Documentation support on feature change/addition
  • āŒ User Guide Documentation support on feature change/addition
  • āŒ Accessibility and Readability
  • āŒ Code review from 1 Varbase core team member
  • āŒ Full testing and approval
  • āŒ Credit contributors
  • āŒ Review with the product owner
  • āŒ Update Release Notes and Update Helper on new feature change/addition
  • āŒ Release

Varbase update type

  • āœ… No Update
  • āž– Optional Update
  • āž– Forced Update
  • āž– Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
šŸ“Œ Task
Status

Needs work

Version

10.0

Component

Code

Created by

šŸ‡®šŸ‡³India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sidharth_soman
  • Assigned to sidharth_soman
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India sidharth_soman Bangalore
    C:\xampp\htdocs\backendassignment\web\modules\contrib>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig varbase_bootstrap_paragraphs

FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\css\base\vbp-default.admin.css
-----------------------------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 20 LINES
-----------------------------------------------------------------------------------------------------------------------
   1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 181 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 182 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 183 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 184 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 185 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 228 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 247 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 248 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 249 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 250 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 251 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 294 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 295 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 296 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 327 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 328 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 329 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 330 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 367 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\css\base\vbp-default.base.css
----------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 41 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------


FILE: ...tdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\css\component\vbp-accordion.component.css
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\css\component\vbp-carousel.component.css
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...pp\htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\css\component\vbp-image.component.css
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...pp\htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\css\component\vbp-modal.component.css
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...mpp\htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\css\component\vbp-tabs.component.css
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\css\theme\vbp-colors.theme.css
-----------------------------------------------------------------------------------------------------------------------
FOUND 41 ERRORS AFFECTING 41 LINES
-----------------------------------------------------------------------------------------------------------------------
   1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
  76 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
  77 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
  78 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
  79 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
  93 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
  94 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
  95 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
  96 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 110 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 111 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 112 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 113 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 127 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 128 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 129 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 130 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 144 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 145 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 146 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 147 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 161 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 162 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 163 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 164 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 178 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 179 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 180 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 181 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 195 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 196 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 197 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 198 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 212 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 213 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 214 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 215 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 229 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 230 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 231 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 232 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 41 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------


FILE: ...docs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\modules\vbp_text_and_image\css\default.css
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...dassignment\web\modules\contrib\varbase_bootstrap_paragraphs\modules\vbp_text_and_image\vbp_text_and_image.install
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 119 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...ndassignment\web\modules\contrib\varbase_bootstrap_paragraphs\modules\vbp_text_and_image\vbp_text_and_image.module
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
  1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
 35 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found
    |       |     "_varbase_bootstrap_paragraphs_text_and_image_add_template_variable" but expected
    |       |     "vbp_text_and_image__varbase_bootstrap_paragraphs_text_and_image_add_template_variable"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...endassignment\web\modules\contrib\varbase_bootstrap_paragraphs\src\Form\VarbaseBootstrapParagraphsSettingsForm.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...signment\web\modules\contrib\varbase_bootstrap_paragraphs\tests\src\Functional\VarbaseBootstrapParagraphsTests.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...mpp\htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\varbase_bootstrap_paragraphs.install
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 47 | ERROR   | [x] Doc comment long description must end with a full stop
 51 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...ampp\htdocs\backendassignment\web\modules\contrib\varbase_bootstrap_paragraphs\varbase_bootstrap_paragraphs.module
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 53 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

Time: 3.74 secs; Memory: 10MB

    PHPCS gives the errors as above. I am working on fixing them.

  • @sidharth_soman opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago ā†’
    šŸ‡®šŸ‡³India sidharth_soman Bangalore

    I have created an MR. Please review.

  • Status changed to Needs work 3 months ago
  • Comment 3 months ago ā†’
    šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @sidharth_soman,

    I applied MR!2, it was not applied smoothly.

    These are the issues I encountered after I applied the MR and run phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

    āžœ  varbase_bootstrap_paragraphs git:(10.0.x) curl https://git.drupalcode.org/project/varbase_bootstrap_paragraphs/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 12133    0 12133    0     0  27090      0 --:--:-- --:--:-- --:--:-- 27143
patching file css/base/vbp-default.admin.css
patching file css/base/vbp-default.base.css
Hunk #1 FAILED at 38.
1 out of 1 hunk FAILED -- saving rejects to file css/base/vbp-default.base.css.rej
patching file css/theme/vbp-colors.theme.css
Hunk #6 FAILED at 158.
Hunk #7 FAILED at 175.
Hunk #8 FAILED at 192.
Hunk #9 FAILED at 209.
Hunk #10 FAILED at 226.
5 out of 10 hunks FAILED -- saving rejects to file css/theme/vbp-colors.theme.css.rej
patching file modules/vbp_text_and_image/vbp_text_and_image.module
Hunk #1 FAILED at 32.
1 out of 1 hunk FAILED -- saving rejects to file modules/vbp_text_and_image/vbp_text_and_image.module.rej
patching file varbase_bootstrap_paragraphs.install
Hunk #1 FAILED at 44.
1 out of 1 hunk FAILED -- saving rejects to file varbase_bootstrap_paragraphs.install.rej
āžœ  varbase_bootstrap_paragraphs git:(10.0.x) āœ— ..
āžœ  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml varbase_bootstrap_paragraphs

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/varbase_bootstrap_paragraphs/varbase_bootstrap_paragraphs.module
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url.
 58 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
 62 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/varbase_bootstrap_paragraphs/css/theme/vbp-colors.theme.css
--------------------------------------------------------------------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 20 LINES
--------------------------------------------------------------------------------------------------------------------------------
 161 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 162 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 163 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 164 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 178 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 179 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 180 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 181 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 195 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 196 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 197 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 198 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 212 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 213 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 214 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 215 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 229 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 230 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 231 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 232 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/varbase_bootstrap_paragraphs/css/base/vbp-default.base.css
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 41 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/varbase_bootstrap_paragraphs/modules/vbp_text_and_image/includes/updates/v8.inc
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\InstallStorage.
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/varbase_bootstrap_paragraphs/src/Form/VarbaseBootstrapParagraphsSettingsForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\ConfigFormBase.
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 498ms; Memory: 16MB

āžœ  contrib

    Thank you.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024