- Issue created by @gargsuchi
- 🇮🇳India shashank5563 New Delhi
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- Status changed to Needs review
over 1 year ago 9:32am 3 July 2023 - Status changed to Needs work
over 1 year ago 9:37am 3 July 2023 - 🇮🇳India vinaymahale
Please fix the below PHPCS issues:
FILE: /font_resize/README.md ----------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ----------------------------------------------------------------------- 3 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 21 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------- FILE: /font_resize/src/Plugin/Block/ResizeBlock.php -------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 3 WARNINGS AFFECTING 6 LINES -------------------------------------------------------------------------------------------------------------- 22 | WARNING | [ ] Unused variable $label_plus. 23 | WARNING | [ ] Unused variable $label_minus. 24 | WARNING | [ ] Unused variable $label_original. 32 | ERROR | [x] Short array syntax must be used to define arrays 34 | ERROR | [x] Short array syntax must be used to define arrays 35 | ERROR | [ ] The array declaration extends to column 88 (the limit is 80). The array content should be | | split up over multiple lines 35 | ERROR | [x] Short array syntax must be used to define arrays -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------
- 🇮🇳India shashank5563 New Delhi
@gargsuchi, Please make the 9.1.x branch as default branch. So it will easy to reviewed. Other reviewer will confused which branch need to review.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.
Have you made any other project (module, theme, distribution) that we could instead review?
- Status changed to Closed: won't fix
11 months ago 6:44pm 6 March 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
In this case, it is also necessary to use a different project for the application, as per my previous comments.