- Issue created by @Priya_Degwekar
- Assigned to Priya_Degwekar
- @priya_degwekar opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:13am 1 July 2023 - 🇮🇳India Priya_Degwekar
Hi!
I have opened #MR3 to fix the issue.
Please review.
Hope it helps ..Thanks :) - Assigned to sonam_sharma
hello @Priya_Degwekar
I have fixed all the issues reported by phpcs- @priya_degwekar opened merge request.
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 7:56am 3 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what needs to be fixed/changed. A phrase like Doc comment are missing is not a sufficient description.
- Status changed to Needs review
over 1 year ago 9:37am 3 July 2023 - Status changed to RTBC
over 1 year ago 3:38pm 3 July 2023 - 🇵🇭Philippines roberttabigue
Hi,
I reviewed the changes and MR applied cleanly.
Checking patch library_generator.module... Applied patch library_generator.module cleanly.
Confirmed the ".module" file has been updated accordingly.
Applied to Library Generator module with 1.x-dev version and with the Drupal core version of 9.5.x.
Attaching screenshots.
I'm moving this now to RTBC.
Thanks!
- Status changed to Needs work
over 1 year ago 5:44pm 3 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+/** + * @file + * Module library_generator. + */
The usual description is Hook implementations for the [module name] module. where [module name] is the module name shown in the .info.yml file.
+/** + * Using function hook_info_alter(). + */ function library_generator_library_info_alter(&$libraries, $extension) {
That is not the documentation comment that must be used for hook implementations.
/** + * Using class LibraryGeneratorDiscovery(). + * * @todo Add class description. */ class LibraryGeneratorDiscovery {
That description does not make sense; a class does not use itself. If it made sense, it could be written for every class, which means that description is not specific for that class.
/** * The cache key. + * + * @var cacheKey
That is not a valid PHP type; It is the property name, which does not need to be repeated in the
@var
line. - First commit to issue fork.
- @phparkle opened merge request.
-
phparkle →
committed 6ab0b6ce on 1.x
Issue #3371734 by phparkle, sonam_sharma: Add documentation comments
-
phparkle →
committed 6ab0b6ce on 1.x
- 🇭🇰Hong Kong phparkle
Thanks for the reminder to add the necessary documentation.
- Status changed to Fixed
over 1 year ago 8:12am 4 July 2023 - Status changed to Fixed
over 1 year ago 8:46am 4 July 2023