Fast404EventSubscriber incorrect parameter(s) for onKernelRequest() and onNotFoundException() methods

The last submitted patch, 2: fast_404-3371406.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Assigning this to me to assess.

@jrobison Thanks for the issue and patch. I assume you are running on Drupal 9.5?

This fails on 10.0 with:

https://www.drupal.org/pift-ci-job/2706055 →

1) Drupal\Tests\fast404\Functional\Fast404PathTest::testPathCheck
Exception: TypeError: Drupal\fast404\EventSubscriber\Fast404EventSubscriber::onNotFoundException(): Argument #1 ($event) must be of type Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent, Symfony\Component\HttpKernel\Event\ExceptionEvent given
Drupal\fast404\EventSubscriber\Fast404EventSubscriber->onNotFoundException()() (Line: 73)

so it needs work. But, we need to know what version the original problem was on before proceeding so marking postponed for now. If the method signatures have to change due to Symfony changes, we can either:

1) Create a new branch that is D10 only with the required change (i.e. a new major version) or

2) Use reflection and have two Fast404EventSubscriber classes that load based on version

Option 2 is messier but lets people stay on the same major version for both 9 and 10.

the proposed patch appears to be for Drupal 8

perhaps set the 3x branch as

^9.5 | ^10

drop 8

Thanks for the link. That was for 9.0 and 9.1 so maybe it changed again at some point? The 9.5 automated test ran fine.

@Kristen Pol

The above user is trying to regress Drupal 10 by returning to the Drupal 8 api used by symfony < 4

Symfony 6+ does not have what the above patch includes.

The way forward is for fast_404 to Drop support for Drupal 8

The problem the above user is having is he is using Drupal 8 not drupal 9.5+

his code base cannot handle the new api because his core is way way past due date.

The problem was caused by the fast_404.info.yml file advertising that it was compatible with Drupal 8 or <=9.3, when in fact it is not compatible with those older versions of symfony required by those older releases of core.

The solution to this is to edit the fast_404.info.yml , drop 8,
should require

^9.5 || ^10

This is the solution:

diff --git a/fast404.info.yml b/fast404.info.yml
index 9cc83d3be5e5e6ce8f4311f310c673de8959f0b1..bc3c315ea68cfb95f1ac8e0eb2cc77b92c3bf1fe 100644
--- a/fast404.info.yml
+++ b/fast404.info.yml
@@ -2,4 +2,4 @@ name: 'Fast 404'
 description: 'Speed up the generation of 404 pages with this module. Route 404 display to a static page.'
 type: module
 package: 'Performance and scalability'
-core_version_requirement: ^8.8 || ^9 || ^10
+core_version_requirement: ^9.5 || ^10

Please upgrade to Drupal 9.5+ or downgrade fast_404 to an older version that supports D8.8 -> D9.4 correctly.

https://www.drupal.org/project/fast_404/releases/8.x-3.2 →

Automatically closed - issue fixed for 2 weeks with no activity.