Fix failing tests and code style issues

Created on 29 June 2023, about 1 year ago

Problem/Motivation

	2	Foundation_anchor_menu_block.Foundation_anchor_menu_block
	2	Foundation_anchor_menu_block.Drupal\Tests\foundation_anchor_menu_block\Functional\FoundationAnchorMenuBlockFunctionalTest
	✗	
Drupal\Tests\foundation_anchor_menu_block\Functional\FoundationAnchorMenuBlockFunctionalTest

exception: [Other] Line 0 of sites/default/files/simpletest/phpunit-1.xml:
PHPUnit Test failed to complete; Error: PHPUnit 9.5.26 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\foundation_anchor_menu_block\Functional\FoundationAnchorMenuBlockFunctionalTest
ERE                                                                 3 / 3 (100%)E

Time: 00:04.100, Memory: 6.00 MB

There were 3 errors:

1) Drupal\Tests\foundation_anchor_menu_block\Functional\FoundationAnchorMenuBlockFunctionalTest::testInstallation
Undefined array key "embed"

/var/www/html/core/lib/Drupal/Core/Extension/ModuleInstaller.php:117
/var/www/html/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:474
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:543
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:362
/var/www/html/modules/contrib/foundation_anchor_menu_block/tests/src/Functional/FoundationAnchorMenuBlockFunctionalTest.php:52
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

2) Drupal\Tests\foundation_anchor_menu_block\Functional\FoundationAnchorMenuBlockFunctionalTest::testUninstallation
Undefined array key "embed"

/var/www/html/core/lib/Drupal/Core/Extension/ModuleInstaller.php:117
/var/www/html/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:474
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:543
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:362
/var/www/html/modules/contrib/foundation_anchor_menu_block/tests/src/Functional/FoundationAnchorMenuBlockFunctionalTest.php:52
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

3) Drupal\Tests\foundation_anchor_menu_block\Functional\FoundationAnchorMenuBlockFunctionalTest::testBlockIsPlaceable
Undefined array key "embed"

/var/www/html/core/lib/Drupal/Core/Extension/ModuleInstaller.php:117
/var/www/html/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:474
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:543
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:362
/var/www/html/modules/contrib/foundation_anchor_menu_block/tests/src/Functional/FoundationAnchorMenuBlockFunctionalTest.php:52
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

--

There was 1 risky test:

1) Drupal\Tests\foundation_anchor_menu_block\Functional\FoundationAnchorMenuBlockFunctionalTest::testInstallation
This test did not perform any assertions

/var/www/html/core/tests/Drupal/Tests/Listeners/DrupalListener.php:66
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:452
/var/www/html/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:377
/var/www/html/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:187
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestSuite.php:673
/var/www/html/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:661
/var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/var/www/html/vendor/phpunit/phpunit/src/TextUI/Command.php:97

ERRORS!
Tests: 3, Assertions: 0, Errors: 3, Risky: 1.

	✗	
Unknown

fail: [run-tests.sh check] Line 0 of :
FATAL Drupal\Tests\foundation_anchor_menu_block\Functional\FoundationAnchorMenuBlockFunctionalTest: test runner returned a non-zero error code (2).

5 coding standards messages

✓ 62 fewer than previous result
	
/var/www/html/modules/contrib/foundation_anchor_menu_block/js/famb_anchor_menu.js ✓ 62 fewer
line 52	Parsing error: Unexpected token ?
css/famb_anchor_editor_preview.css
5	Unqualified attribute selectors are known to be slow.
8	Use of !important
9	Use of !important
css/famb_anchor_menu.css
1	Additional whitespace found at start of file

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024