PHPCS: \Drupal calls should be avoided in classes, use dependency injection instead, other issues

Hi @arti_parmar,
Since a long time no actions on this issue so i assigning this issue to myself.
I am working on it.

Please review the patch.

Thanks for the work so far on this. The patch looks fine, except for the fact that it only addresses a single file. To actually rectify the issue raised by the title of this issue would require an unreasonably large number of issues, if the use of \Drupal calls would be addressed one file at a time.

I would prefer a patch that addresses all use of \Drupal, or if that leads to an unreasonably large patch, one issue / patch per type of call (service, entityTypeManager, etc.

No more \Drupal calls warnings. Ran vendor/bin/phpcs --standard=DrupalPractice,Drupal --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/smart_date-3370895
Please review MR #7.

When you run cs command for entire module, you'll see lot of error/issues. Please see attached file. I will be working on these errors accordingly.

Thanks for all the work on this issue, especially @Jasjeet Kaur Brar. These changes have been merged in.

Automatically closed - issue fixed for 2 weeks with no activity.