t() calls should be avoided in classes

Open on Drupal.org →

Created on 26 June 2023, about 1 year ago

Updated 27 January 2024, 5 months ago

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\block_visibility_groups\src\BlockVisibilityGroupedListBuilder.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
130 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
435 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\block_visibility_groups\tests\src\Functional\BlockVisibilityGroupsUiTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
71 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

📌 Task

Status

Fixed

Version

2.0

Component

Code

Created by

🇮🇳India arti_parmar

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @arti_parmar
Issue was unassigned.
Status changed to Needs review about 1 year ago9:34am 26 June 2023
Comment about 1 year ago →
🇮🇳India arti_parmar
Kindly review patch.
Status changed to Needs work 6 months ago3:25pm 8 January 2024
Comment 6 months ago →
🇺🇸United States DamienMcKenna NH, USA
Thank you for putting this together. The first change is fine, but strings shouldn't be translated in tests like that, so the correct change there would be to simply remove the t() usage entirely in the test.
Status changed to Needs review 6 months ago4:54am 9 January 2024
Comment 6 months ago →
🇮🇳India sidharth_soman Bangalore
Modified #3's patch to remove the translation. There are no other occurrences of t() usage anywhere else in the tests.
Comment 6 months ago →
System Message

DamienMcKenna → committed bcefa975 on 2.0.x authored by arti_parmar →
Issue #3370069 by arti_parmar, sidharth_soman, DamienMcKenna: t() calls...
Status changed to Fixed 6 months ago8:40pm 13 January 2024
Comment 6 months ago →
🇺🇸United States DamienMcKenna NH, USA
Perfect! Thank you. Committed.
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024