- Issue created by @mingsong
- last update
over 1 year ago Build Successful - @mingsong opened merge request.
- Status changed to Needs review
over 1 year ago 8:29am 26 June 2023 -
Mingsong β
authored 6ca80dab on 3.0.x
Issue #3370034: PHPUnit test for this module
-
Mingsong β
authored 6ca80dab on 3.0.x
- Status changed to Needs work
over 1 year ago 3:46pm 26 June 2023 -
smustgrave β
committed acb1b533 on 3.0.x
Revert "Issue #3370034: PHPUnit test for this module"
-
smustgrave β
committed acb1b533 on 3.0.x
- last update
over 1 year ago Build Successful - π¦πΊAustralia mingsong π¦πΊ
Did come across any error by my local test.
I upload the patch here to test it via Gitlab.
- last update
over 1 year ago Composer require-dev failure - last update
over 1 year ago Composer require-dev failure - last update
over 1 year ago Composer require-dev failure - π¦πΊAustralia mingsong π¦πΊ
Problem 1
- Root composer.json requires drupal/event_log_track-event_log_track, it could not be found in any version, there may be a typo in the package name.I think it is the project name issue.
- π¦πΊAustralia mingsong π¦πΊ
It might be the typo in those sub modules' info.yml file.
- last update
over 1 year ago Composer require-dev failure - Status changed to Postponed
about 1 year ago 5:37pm 29 August 2023 - πΊπΈUnited States smustgrave
So I think we will need a settings to log CLI changes.
Also some weirdness because the original maintainer names the project events_log_track but names evertyhing event_log_track
- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 1 pass - last update
about 1 year ago 1 pass - Status changed to Needs review
about 1 year ago 8:28pm 15 November 2023 - πΊπΈUnited States smustgrave
@Mingsong got this working now with 1 test.
Could start a META for tracking additional ones but lets get one to land for next release.
- Status changed to Needs work
about 1 year ago 5:55am 16 November 2023 - π¦πΊAustralia mingsong π¦πΊ
I just saw another issue where the $LogOnCLI parameter comes from.
#3205398: Allow log entries also on CLI operations β
If we remove it, it will affect their custom module/drush command.
The reason I suggest removing it is that, basically there are two variables to decide if this module will log cli actions.
This might cause confusion where the log_cli configuration is set to false in the setting form of this module, but cli logs might still are logged as $LogOnCLI parameter passed into that function is true.
- πΊπΈUnited States smustgrave
We can deprecate it and remove in 4.0.x whenever that happens
- Status changed to RTBC
about 1 year ago 10:47pm 16 November 2023 - π¦πΊAustralia mingsong π¦πΊ
Then it looks good me. So I mark it as RTBC.
Thanks again.
- last update
about 1 year ago Composer require-dev failure - π¦πΊAustralia mingsong π¦πΊ
@Stephen, I add a new test for CLI action log to ensure by default CLI action won't be logged.
Here is the new patch for 3.0.x branch.
- Status changed to Needs review
about 1 year ago 12:01am 20 November 2023 - π¦πΊAustralia mingsong π¦πΊ
For you review. We are almost there.
- last update
about 1 year ago Composer require-dev failure - last update
12 months ago 1 pass - last update
12 months ago 1 pass - last update
12 months ago 1 pass -
smustgrave β
committed 9b58cfbb on 3.0.x
Resolve #3370034 "Add simple test"
-
smustgrave β
committed 9b58cfbb on 3.0.x
- Status changed to Fixed
12 months ago 8:43pm 27 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.