- Issue created by @pameeela
- First commit to issue fork.
- 🇳🇿New Zealand heathergaye
I've had a go at this now.
My main hangup is that the scripts for the page top and bottom need script tags, but scripts in the head are added as attachments, and they must exclude script tags. Don't know the best way to handle this. I put a comment in the snippet description; guidance for the user may be sufficient. We could strip tags out on saving and/or validate & error out, but I don't know how many varying use cases we might need to cover.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
For a client who was behind a WAF and couldn't submit POST entries with script tags, we wrote a module to split the textarea into three fields (html, css, js) and then reconstituted that into separate tags.
Perhaps that's an option here?
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Took a look at the MR, that looks reasonable to me.
Perhaps we could add validation to the form to check for
<script>when the position is head? - 🇳🇿New Zealand heathergaye
I've now added validation to check for script tags if head position is specified (and fixed my commit workflow on the fork. Everything is on the issue branch).
- Status changed to Needs review
over 1 year ago 2:55pm 2 August 2023 - 🇦🇺Australia pameeela
I know Lee is away all month but maybe @acbramley or @dpi could give us a review :)
- last update
over 1 year ago 4 fail - @pameeela opened merge request.
- 🇦🇺Australia pameeela
Just realised there was no MR for this so I created one.
- Status changed to Needs work
over 1 year ago 2:39am 7 September 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Looking good, left a couple of minor comments on the MR
It looks like we have a failing test too?
