Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 24 June 2023, over 1 year ago
Updated 2 September 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Project Update Bot
  • Comment over 1 year ago →
    Project Update Bot

    This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

    It is important that any automated tests available are run with this patch and that you manually test this patch.

    Drupal 10 Compatibility

    According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.

    Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.

    Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #12554

    This patch was created using these packages:

    1. mglaman/phpstan-drupal: 1.1.35
    2. palantirnet/drupal-rector: 0.15.1
  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
     		if (((int) \Drupal::VERSION) < 9) {
-			$file = file_load($fid);
+			$file = \Drupal::service('entity_type.manager')->getStorage('file')->load($fid);
 		} else {

    Since the code first check the Drupal version, this is not the correct change.

  • Assigned to Chandreshgiri Gauswami
  • Comment over 1 year ago →
    🇮🇳India Chandreshgiri Gauswami

    I will work on it.

  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India Chandreshgiri Gauswami

    Attaching patch and interdiff files.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
    +		$file = File::load($fid);
 		$path = 'public://inline-images/' . date('Y-m', time()) . '/' . time() . '/';
-		if (((int) \Drupal::VERSION) < 9) {
-			if (file_prepare_directory($path, FILE_CREATE_DIRECTORY) && !file_exists($path)) {
-				file_copy($file, $path);
-			}
-			$images = file_scan_directory($themeLink . '/content/images', '/.*\.jpg|jpeg|gif|png|pdf|doc|zip|rar|docx|7zip|txt|rtf|odt|7z|ods$/');
-			$videos = file_scan_directory($themeLink . '/video', '/.*\.mp4$/');
-		} else {
-			if (\Drupal::service('file_system')->prepareDirectory($path, FileSystemInterface::CREATE_DIRECTORY) && !file_exists($path)) {
-				file_copy($file, $path);
-			}
-			$images_dir = $themeLink . '/content/images';
-			if (is_dir($images_dir)) {
-				$images = \Drupal::service('file_system')->scanDirectory($images_dir, '/.*\.jpg|jpeg|gif|png$/');
-			}
-			$videos_dir = $themeLink . '/video';
-			if (is_dir($videos_dir)) {
-				$videos = \Drupal::service('file_system')->scanDirectory($videos_dir, '/.*\.mp4$/');
-			}
+		if (\Drupal::service('file_system')->prepareDirectory($path, FileSystemInterface::CREATE_DIRECTORY) && !file_exists($path)) {
+			\Drupal::service('file.repository')->copy($file, $path);
+		}
+		$images_dir = $themeLink . '/content/images';
+		if (is_dir($images_dir)) {
+			$images = \Drupal::service('file_system')->scanDirectory($images_dir, '/.*\.jpg|jpeg|gif|png$/');
+		}

    This change is not correct either, since that code would not work on Drupal 8, which is included in the core_version_requirement value used by the theme.

  • Comment about 1 year ago →
    🇮🇳India Chandreshgiri Gauswami

    I will look into it.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024