Config Sync breaks with Drush 12, need to refactor not to use ConfigImportCommands

This might be useful https://git.drupalcode.org/project/acquia_cms_common/-/commit/a80b619d9c...

Fantastic, thank you for this! Hoping someone can review before i get to it. Your notes on how to test are great too, thank you trackleft2.

As far as I can tell, the Drush\Drupal\Commands\config\ConfigImportCommands dependency that is currently being injected into the ConfigSyncCommands is not actually being used so I think the MR could be simplified a bit to just remove that dependency altogether rather than replace it with the new Config Distro service.

We may also want to hold off on merging this until after the related Config Distro issue is resolved ( 🐛 Config Distro breaks with Drush 12, need to refactor not to use ConfigImportCommands Fixed ).

MR !10 is ready for review.

Thank you for your work on this! Tested out MR !10 locally with Drush 12.1.3. Verified the original issue:

$ drush config-sync-list-updates
In LegacyServiceInstantiator.php line 282:                       
  You have requested a non-existent parameter "config.import.commands". 

Verified that with the changes in MR !10 the error does not occur, and config_sync reports expected changes correctly:

$ drush config-sync-list-updates
 ----------------- ---------------- ----------------- 
  Extension         Operation type   Label            
 ----------------- ---------------- ----------------- 
  my_test_content   update           My Content Type  
 ----------------- ---------------- -----------------

config_sync tests pass:

PHPUnit 9.6.10 by Sebastian Bergmann and contributors.

Testing /usr/local/config_sync
....                                                                4 / 4 (100%)

There is one minor phpcs complaint about the create() function:
74 | ERROR | [x] Missing function doc comment (Drupal.Commenting.FunctionComment.Missing)

And one minor complaint about the $state. in the docblock of the constructor:
58 | ERROR | [x] Doc comment parameter name "$state." must not end with a dot (Drupal.Commenting.FunctionComment.ParamNameDot)
This error was unrelated and not introduced by this MR though.

Merged. Thanks all!

Automatically closed - issue fixed for 2 weeks with no activity.