- Issue created by @project update bot
- Status changed to Needs review
over 1 year ago 9:23pm 23 June 2023 This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #12554This patch was created using these packages:
- mglaman/phpstan-drupal: 1.1.35
- palantirnet/drupal-rector: 0.15.1
- Assigned to roshni27
- Status changed to Needs work
over 1 year ago 10:09am 18 July 2023 - 🇮🇳India roshni27
I have applied the above patch. It has solved all errors except the two warnings indicated in the screenshot. I am working on resolving them and will upload a new patch once done.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:17am 18 July 2023 - 🇬🇧United Kingdom somersoft
@roshni27 These changes are also now present in code fork https://git.drupalcode.org/issue/course_relationships-3220941 for the associated issue.
- 🇨🇦Canada avo webworks Ottawa, Ontario, Canada
While using the patch I get an error:
Error: Call to undefined function variable_get() in course_relationships_cron() (line 464 of ......./modules/contrib/course_relationships/course_relationships.module)variable_get is replaced by:
\Drupal::state()->get - 🇨🇦Canada avo webworks Ottawa, Ontario, Canada
Here is the patch file includes patch comment 5 as well as the issue below:
Error: Call to undefined function variable_get() in course_relationships_cron() (line 464 of ......./modules/contrib/course_relationships/course_relationships.module)variable_get is replaced by:
\Drupal::state()->get - 🇬🇧United Kingdom niklp Nottingham
As mentioned by @somersoft in #6, the fix AND the necessary changes for the D10 upgrade are included in the branch https://git.drupalcode.org/issue/course_relationships-3220941
- 🇨🇦Canada avo webworks Ottawa, Ontario, Canada
@NikLP and @somersoft the issue in comment #8 is not included in the branch https://git.drupalcode.org/issue/course_relationships-3220941 which still uses the variable_get... the patch in #8 does include in this fix.
- 🇬🇧United Kingdom somersoft
@AvO WebWorks Thank you for your help with creating a D9/10 version of this package.
All the changes are in the branch 3220941-any-plan-for in that respository as per Creating issue forks → .
Please do continue to review the changes and feel free to request push access to that repository to updated that branch with any further changes.I think PHP will not load a code file if any of the use classes are not present. This is one of the reasons why the modules course_relationships_credit and course_relationships_uc were created.
This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.18.6, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.yml
file for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #70004This patch was created using these packages:
- mglaman/phpstan-drupal: 1.2.4
- palantirnet/drupal-rector: 0.18.6
- 🇬🇧United Kingdom somersoft
The above Project Update Bot has prompted running rector over the code and it has been updated in the related issue https://git.drupalcode.org/issue/course_relationships-3220941.
This patch was created using these packages:
- mglaman/phpstan-drupal: 1.2.6
- palantirnet/drupal-rector: 0.19.2