Drupal 10 compatibility

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module → , even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.

Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. mglaman/phpstan-drupal: 1.1.35
2. palantirnet/drupal-rector: 0.15.1

There was an error in the tests/src/Kernel/Plugin/migrate/BeanDeriverTestBase.php file.

I've given this a test out locally and seems to do the trick and the module is working on D10.

I haven't tested the tests as it were, but this gets the module installing.

Thanks, @rossb89, for letting us know that @Soubi's patch in #6 worked for you!

I'd love to see at least one more confirmation 😇

Ehm … clearly nobody has ever run the tests on Drupal 10, because they fail immediately, and hard. And after you fix those failures, you run into the same problems that 🐛 Tests fail since Drupal 9.5 Needs review is fixing. So postponing on that.

Wim Leers → credited himanshu_jhaloya → .

#3354022 landed — see #3354022-6: Tests fail since Drupal 9.5 → .

Rebasing #6 on top of that and merging in 📌 Automated Drupal 10 compatibility fixes Needs work , and crediting @himanshu_jhaloya for that work!

P.S.: this will need a new branch, because this must drop support for Drupal 8 — and actually also <9.5.

Closed 📌 Drupal 10 compatibility Needs work as a duplicate too.

This is #6 + 📌 Automated Drupal 10 compatibility fixes Needs work .

Still lots of work, because tests are nowhere near passing.

Core's migrations (and test suite) also had to be updated in #3281427: Update Block and Theme setting migrations to not use Bartik and Seven → to stop relying on Bartik. That's one of the most crucial things that's still missing.

Fix composer.json, to allow this to run on D9 too.

Unit tests are now passing locally. Also, start using GitLab CI. But that requires a merge request. So … did that.

Apparently 📌 [PHPUnit 10] @dataProvider methods must be declared static and public Fixed only landed in Drupal 11, so I'll need to revert some changes.

That also means that it's impossible to be compatible with both Drupal 10.2 and 11 … that'll be interesting. Hopefully 10.3 will contain some kind of solution to allow supporting both simultaneously.

✨ Introduce database driver extensions and autoload database drivers' dependencies Fixed caused the

Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "mysql[host]" not found.

failures on Drupal >=10.

The locale-related failure could be related to 📌 Fix and re-enable MigrateBlockContentTranslationTest Active , for which \Drupal\Tests\block\Kernel\Migrate\d7\MigrateBlockContentTranslationTest::testBlockContentTranslation() is being skipped…

There was 1 error:
1) Drupal\Tests\bean_migrate\Kernel\BeanMigrateMultilingualTest::testMigrations
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "locale.config_manager".

occurs only on Drupal 10, due to #2953111: Only migrate role permissions that exist on the destination → , which was intentionally not backported, see #2953111-237: Only migrate role permissions that exist on the destination → and surrounding comments. This is causing a nightmare for us now it seems.

Holka_a → changed the visibility of the branch d10_t2 to hidden.

Holka_a → changed the visibility of the branch d10_t to hidden.

Holka_a → changed the visibility of the branch df_d10_readiness to hidden.

Holka_a → changed the visibility of the branch d10_ready_final to hidden.