Contrib.social

Remove some preprocess hooks

Open on Drupal.org →
Created on 22 June 2023, about 1 year ago
Updated 25 June 2023, about 1 year ago

Problem/Motivation

Those hooks in the .theme file are a lot of PHP code for a codebase which must be owned by a front developer.

Proposed resolution for Bootstrap 4

  • ui_suite_bootstrap_preprocess_pattern_card: use add_class filter
  • ui_suite_bootstrap_preprocess_pattern_carousel: use preview template
  • ui_suite_bootstrap_preprocess_pattern_figure: use add_class filter
  • ui_suite_bootstrap_preprocess_pattern_pagination: move menu to a setting
  • ui_suite_bootstrap_preprocess_pattern_dropdown: use add_class filter, use set_attribute filter

Commit directly in branch 4.x

Proposed resolution for Bootstrap 5

In scope:

  • PreprocessPatternAccordionItem: use random() function?
  • PreprocessPatternAccordion: use random() function?
  • PreprocessPatternAlert.php: use set_attribute filter?
  • PreprocessPatternCardBody: use add_class filter
  • PreprocessPatternCard: use add_class filter
  • PreprocessPatternCarousel: use random() function
  • PreprocessPatternFigure: use add_class filter? May be complicate for #item_attributes
  • PreprocessPatternModal: use random() function
  • PreprocessPatternOffcanvas: use random() function

Do a merge request

Will be done in 🐛 Bootstrap 5: dropdown is too complicated (outdated) Closed: outdated :

  • PreprocessPatternDropdown: use random() function
  • PreprocessPatternNavbarNav: use add_class filter? move menu to a setting?
  • PreprocessPatternNavbar: use random() function. Is DarkSetting deprecated?
  • PreprocessPatternNavItem: use add_class filter?
📌 Task
Status

Fixed

Version

5.0

Component

Code

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024