- Issue created by @vishal365365
- Status changed to Needs review
over 1 year ago 5:22pm 22 June 2023 - Status changed to Needs work
over 1 year ago 5:24am 23 June 2023 - 🇵🇭Philippines paraderojether
Hi I reviewed patch #2, and there are still remaining issues reported by phpcs after applying the patch:
FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/entity_reference_patterns/entity_reference_patterns.info.yml ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/entity_reference_patterns/src/Element/EntityAutocomplete.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 10 | WARNING | Line exceeds 80 characters; contains 90 characters 68 | WARNING | Line exceeds 80 characters; contains 100 characters ------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/entity_reference_patterns/src/EntityReferencePatternMatcher.php ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ---------------------------------------------------------------------------------------------------------------------------------------------- 19 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 48 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 49 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 66 | WARNING | Line exceeds 80 characters; contains 104 characters 70 | WARNING | Line exceeds 80 characters; contains 86 characters ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/entity_reference_patterns/src/Controller/EntityAutocompleteController.php -------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | Namespaced classes/interfaces/traits should be referenced with use statements -------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/entity_reference_patterns/src/EntityReferencePatterns.php ---------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------------------- 20 | ERROR | Public method name "EntityReferencePatterns::hook_options_list_alter" is not in lowerCamel format 22 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 23 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 32 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ---------------------------------------------------------------------------------------------------------------------------------------- Time: 388ms; Memory: 10MB
Please check.
Thank You. - Assigned to arti_parmar
- 🇮🇳India arti_parmar
yes , I have reviewed and implemented the #patch 2 and its not resolving all the issues.
still getting error Please see the screenshots attached.
Thank you - Status changed to Needs review
over 1 year ago 7:04am 23 June 2023 - Issue was unassigned.
- 🇮🇳India Raveen Kumar
arti, your patch is having some issues. I am applying the patch using composer but it is saying: - Applying patches for drupal/entity_reference_patterns
https://www.drupal.org/files/issues/2023-06-23/3368768-6.patch → (phpcs)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-06-23/3368768-6.patch →Could you please re-check.
I applied patch#2, It successfully applied but the phpcs issues were not completely resolved. So i tried your patch but it is giving error.
- Status changed to Needs work
over 1 year ago 7:25am 23 June 2023 - 🇮🇳India roshni27
I applied patch#2, It successfully applied but the phpcs issues and dependency issues were not completely resolved. So i tried patch #6 but it is giving error.
- Assigned to roshni27
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:49pm 17 July 2023 - 🇮🇳India roshni27
For reading purpose charter limits error remain .Please review the patch.