- Issue created by @Harshita mehra
- Status changed to Needs review
over 1 year ago 12:12pm 22 June 2023 - last update
over 1 year ago 1 pass - 🇮🇳India Harshita mehra
Hello Maintainers and everyone,
I have provided a patch for this issue.
Please review it.Thanks!
- Status changed to RTBC
over 1 year ago 11:06am 20 July 2023 - 🇵🇭Philippines kenyoOwen
Hi Harshita mehna
I applied your patch and confirmed that it resolved the issues about t() calls should be avoided in classes. Please look at the screenshot I attached for your reference
Thank you
- Status changed to Needs work
over 1 year ago 11:53am 20 July 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The patch could apply, but the change is not correct.
$out['git_info']['#markup'] = - t('<p>Current version information: %v</p>', ['%v' => $git->getApplicationVersionString()]); + $this->t('<p>Current version information: %v</p>', ['%v' => $git->getApplicationVersionString()]);
The last line must be indented like the second one.
- Status changed to Needs review
over 1 year ago 1:15pm 20 July 2023 - last update
over 1 year ago 1 pass