\Drupal calls should be avoided in classes, use dependency injection instead

Kindly review patch.

Patch #2 applies cleanly.

However, there is still a dependency injection error left in one of the files. I am attaching the relevant screenshots.

Hence, moving back to 'Needs Work'.

Thanks for the patch and the review.

But please don't post screenshots that just show a patch applying or text!

Updated patch #2 by addressing #3, please review it.

Thanks & Regards,
Mrinalini

Committed, with the following fixes:

1. +++ b/src/ComputedFieldBuilder.php
   @@ -18,15 +20,36 @@ class ComputedFieldBuilder implements TrustedCallbackInterface {
   +  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
   +    return new static(
   +      $container->get('entity_type.manager'),
   +      $container->get('render_placeholder_generator')
   +    );
   

   That's wrong -- this is a service. The yml file needs to be changed. This will currently crash.

2. +++ b/src/ComputedFieldBuilder.php
   @@ -68,13 +91,14 @@ class ComputedFieldBuilder implements TrustedCallbackInterface {
   -      ])];
   +      ]),
   +      ];
   

   That shouldn't be changed.

Thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.