- Issue created by @phpsubbarao
- First commit to issue fork.
- 🇳🇱Netherlands nvandijk
nvandijk → changed the visibility of the branch 3368585-auto-redirect-if to hidden.
- Merge request !53Remove check if ajaxing to redirect if user does not interact with dialog → (Merged) created by nvandijk
- Status changed to Needs review
about 1 year ago 9:37am 21 December 2023 - 🇳🇱Netherlands nvandijk
Merge request is for the current dev version, patch is for the current (1.4) release.
- Status changed to RTBC
about 1 year ago 9:43am 21 December 2023 - 🇳🇱Netherlands timohuisman Leiden, Netherlands
The MR failure seems not to be related to this changes, but a mis-configuration in the Gitlab CI file, not sure though.
The patch is working fine against the 8.x-1.4.
- First commit to issue fork.
- Status changed to Fixed
7 months ago 9:24pm 22 May 2024 -
jrglasgow →
committed c37a654a on 8.x-1.x authored by
nvandijk →
Issue #3368585 by nvandijk: Auto redirect if user didn't click the popup
-
jrglasgow →
committed c37a654a on 8.x-1.x authored by
nvandijk →
I was running into an issue using #6 on 1.4 (using alternative logout) along with patch 3214958-26 to deal with mutable tabs. With this applied, all tabs would trigger the popup without any acknowledgement of the active tab.
Instead of using #6, I fixed this with the following:
if (ajax.ajaxing) { if (theDialog == undefined) { return false; } }
No idea if this is really workable going forward, but the testing today seems to make me think this just might hold up in our environment.
I also ran into trouble with the April 12th build of dev using this patch with the modal popping up in an unfocused tab.
Automatically closed - issue fixed for 2 weeks with no activity.