Contrib.social

Coding standards improvements, inc DI instead of \Drupal calls

Open on Drupal.org →
Created on 22 June 2023, almost 2 years ago
Updated 11 July 2024, 9 months ago

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\memcache\memcache_admin\src\Controller\MemcacheStatisticsController.php
---------------------------------------------------------------------------------------------------------------------------
137 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
282 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
287 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\memcache\memcache_admin\src\EventSubscriber\MemcacheAdminSubscriber.php
---------------------------------------------------------------------------------------------------------------------------
32 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
56 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
60 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
108 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------

📌 Task
Status

Closed: won't fix

Version

2.0

Component

Code

Created by

🇮🇳India arti_parmar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @arti_parmar
  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India yashmalviya

    I have added dependency injection as needed in patch#2. Please review.

  • Comment about 1 year ago →
    🇺🇸United States DamienMcKenna NH, USA

    Thank you for putting this together.

    As a reminder, once you finish your work on an issue the "assigned" field should be set to "Unassigned", that way others will know that you're finished and then they can review & improve it.

  • Comment about 1 year ago →
    🇺🇸United States DamienMcKenna NH, USA

    Clarifying this includes more changes than just DI.

  • First commit to issue fork.
  • Assigned to ankitv18
  • Status changed to Needs work 11 months ago
  • Comment 11 months ago →
    🇮🇳India ankitv18

    Patch is not applied properly, tried to incorporate the changes in the MR with using the Patch mentioned #2

    Will work on this and create a MR.

  • Merge request !28Issue-3368578: Fixing coding standards with DI fixes. → (Open) created by ankitv18
  • Pipeline finished with Failed
    11 months ago
    Total: 175s
    #171110
  • Pipeline finished with Failed
    11 months ago
    #171697
  • Pipeline finished with Failed
    11 months ago
    #171730
  • Pipeline finished with Failed
    11 months ago
    Total: 180s
    #171776
  • Pipeline finished with Failed
    11 months ago
    Total: 176s
    #171837
  • Pipeline finished with Failed
    11 months ago
    #171845
  • Pipeline finished with Failed
    11 months ago
    Total: 147s
    #171853
  • Pipeline finished with Failed
    11 months ago
    Total: 144s
    #172115
  • Pipeline finished with Failed
    11 months ago
    Total: 147s
    #172125
  • Issue was unassigned.
  • Status changed to Needs review 11 months ago
  • Comment 11 months ago →
    🇮🇳India ankitv18

    Except PHPunit(No memcache extension found) all other jobs are passing, please review the MR!28 and merge if possible.

  • Status changed to Closed: won't fix 9 months ago
  • Comment 9 months ago →
    🇺🇸United States japerry KVUO
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024