When creating a new revision, the new revision is always made the default revision if the previous default revision is unpublished

erik.erskine → made their first commit to this issue’s fork.

We have a use case to put a node into an archived state, allow subsequent drafts to be made, and compare those revisions with the archived revision.

The current behaviour - in `EntityOperations.php` - will always update the default revision if the previous revision was unpublished, regardless of what the moderation state's "default revision" property is set to:

$update_default_revision = $entity->isNew()
  || $current_state->isDefaultRevisionState()
  || !$this->moderationInfo->isDefaultRevisionPublished($entity);

The third condition here is very broad. It covers the "only ever been draft" use case, but not the "archived, then draft" use case.

Here is a proposed change that will update default revision in the following circumstances:

• the entity is new (same as now)
• the moderation state dictates the revision should become the default (same as now)
• the previous revision was the default AND the state does not change

Patch/MR done to get things started.

Thank you for reporting.

This will require a test case to show the issue.

Also the MR should be updated for 11.x as that's the current development branch. Fixes can be backported depending when they land.

Thanks.

This was biting me today as part of a broader attempt to make moderation behave the way a client expects.

My current solution is to swap out NodeModerationHandler and override ::onPresave() to avoid changing the default revision unless we are publishing. The handler is marked @internal however so that's not ideal.

My client's expected workflow looks like this:

states:
    initial:
      label: Unpublished draft
      published: false
      default_revision: true
    published:
      label: Published
      published: true
      default_revision: true
    draft:
      label: Pending draft
      published: false
      default_revision: false
    unpublished:
      label: Unpublished
      published: false
      default_revision: true