- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:21pm 21 June 2023 - last update
over 1 year ago 3 pass - Status changed to RTBC
over 1 year ago 1:13pm 21 June 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi arti_parmar
I applied your patch and confirmed that the phpcs issues mentioned are resolved. Please see the screenshots attached.
Thank you.
- Status changed to Needs work
over 1 year ago 4:29pm 21 June 2023 - ๐บ๐ธUnited States dww
Thanks for working in this!
Definitely a task, not a bug. Everything works. This is just a suggestion to improve test-ability, but itโs functionally the same.
Speaking of tests, we shouldnโt be using
t()
there at all. ๐ See ๐ [meta] Remove usage of t() in tests not testing translation Active . So if weโre going to touch the tests here at all, it should be to removet()
, not replace it with$this->t()
.Thanks again!
-Derek - Status changed to Closed: duplicate
over 1 year ago 4:38pm 21 June 2023 - ๐บ๐ธUnited States dww
Oh right, I knew this sounded all too familiar.
๐ Don't use t() within classes Fixed
Please search for existing issues before opening new ones.
Thanks again,
-Derek