Remove the unused variable and method

Comments & Activities

Issue created by @arti_parmar
Issue was unassigned.
Status changed to Needs review about 1 year ago11:32am 21 June 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
54 pass
Comment about 1 year ago →
🇮🇳India arti_parmar
Kindly review patch.
Status changed to RTBC about 1 year ago2:02pm 21 June 2023
Comment about 1 year ago →
🇵🇭Philippines kenyoOwen
Hi arti_parmar

I applied your patch and confirmed that the phpcs issues mentioned are resolved. Please see the screenshots attached.

Thank you.
Status changed to Needs work about 1 year ago9:26am 22 June 2023

🇮🇹Italy apaderno Brescia, 🇮🇹

-      $point = &$form;
+      $point = $form;

Actually, the report is suggesting to remove the $point variable, not to remove & from that line.

-  private function formatList(array $list, $depth = 1) {
+  public function formatList(array $list, $depth = 1) {
     $spacer = '<br />' . str_repeat('&nbsp;', 2 * $depth);
     $output = $spacer . Xss::filter(implode($spacer, $list), ['br']);
     return $output;

The report is saying that method is not used. Fixing that does not mean making the method public.

Status changed to Needs review about 1 year ago7:42am 23 June 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.1 & MySQL 8
last update about 1 year ago
54 pass
Comment about 1 year ago →
🇮🇳India Ajeet Tiwari
tried to resolve the comment #4 and uploading patch for the same.
Status changed to RTBC about 1 year ago3:56pm 23 June 2023
Comment about 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The last patch is correct as per issue topic.