- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:07am 21 June 2023 - Status changed to RTBC
over 1 year ago 7:06am 21 June 2023 - 🇵🇭Philippines paraderojether
Hi I reviewed patch #2, applied it against Omnisend 1.1.0, and confirmed the issue is fixed.
I added screenshot for reference.
Thank You. - Status changed to Needs work
over 1 year ago 11:28am 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
class OmnisendApi -{ +{
That is an off-topic change for an issue that aims to remove the calls to
t()
from classes code. It is also wrong, since the curly parenthesis is placed on the same line containing the class name, in Drupal.I am also curious on why the issue decided to fix a single line, out of all the possible errors/warnings given by PHP_CodeSniffer.
- Status changed to Closed: duplicate
over 1 year ago 11:44am 22 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Furthermore, the report given in 🐛 Fix the issues reported by phpcs Needs review already contains warnings/errors about using
t()
in classes.