- Issue created by @Igumnov_aleksey
- Status changed to Needs work
9 months ago 12:34pm 14 October 2023 - 🇳🇴Norway svenryen
Hi @Igumnov_aleksey!
Thanks you for the concern and the patch. I have tried applying the patch to 7.x-1.x. It doesn't apply and there's already a line saying
$data['css'] = '';(line 236).Since you have a warning reported at line 123, may I ask you to update to the lates 7.x build and see if that resolves your problem?
- 🇮🇳India Mohd Sahzad
I have updated for this issue : Warning: Undefined array key "css" in eu_cookie_compliance_page_build() (line 123 of eu_cookie_compliance/eu_cookie_compliance.module), please check attached patch2.
- Status changed to Needs review
9 months ago 6:32am 16 October 2023 - Status changed to Needs work
9 months ago 3:42pm 16 October 2023 - 🇳🇴Norway svenryen
@Mohd Sahzad could you let me know what branch you're submitting the patch for? I tried applying to 7.x-1.x (dev) and it doesn't apply properly. Note that we are at 7.x-1.43, not 1.14. Is there any reason why you're not at the latest revision?
- 🇮🇳India Mohd Sahzad
@svenryen, this patch was generated for version 7.x-1.14. I updated the patch for this specific version (7.x-1.14) because the issue was created for this version, not the latest one.
- 🇳🇴Norway svenryen
I see. Do you still have this issue/problem when you use the latest 7.x-1.x build? I'm used to people creating patches for the latest build (now 7.x-1.43) or the 7.x-dev branch which you can check out from git.
I'm not really sure how to proceed since the patch doesn't apply and there's no way for us to release something like a 7.x-1.15b.
Hope you understand. If you intend to patch 7.x-1,14 you're welcome to do so, but most likely the issue will be closed stating the patch is outdated.