- Issue created by @quietone
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
(api.drupal.org is still running on Drupal 7; the 1.x branch is for Drupal 9.)
- ๐ช๐ธSpain fjgarlin
Methods in instance: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Routing%2...
Methods in interface: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Routing%2... - ๐ช๐ธSpain fjgarlin
This connection is done in the "api" module. Moving this issue back there.
- ๐บ๐ธUnited States brad.bulger
I don't quite understand what this issue is reporting, but it looks like
{@inheritdoc}
is not working. Child class method pages don't show the annotations from the parent class method. Is that this issue? - ๐ช๐ธSpain fjgarlin
I think ๐ Information is missing from the API pages Active might be related (or even the same but not sure until I check in detail).
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
They seem the same issue, as in both the cases the class implements an interface, which contains the method descriptions that should be shown for the class itself.
- ๐บ๐ธUnited States brad.bulger
Yes, either ๐ Information is missing from the API pages Active is a duplicate of this, or I need to find/create another issue for API, or it's not an API issue (seems unlikely).
I don't know if it is strictly about interfaces. We would have to find a class that extends another class and overwrites a parent class function not defined in the interface. I have done some searching but that's tricky to find.
- ๐บ๐ธUnited States brad.bulger
This information is missing from the 9.x API documentation as well now, for what that's worth.
This seems like a serious problem, in that most of the pages we look for in the API are implementations of something else, and because of whatever problem there is, none of them document their parameters, return values, etc.
- ๐จ๐ฆCanada Charlie ChX Negyesi ๐Canada
This is unusual: there's testing ensuring this doesn't happen, in
ComplexItemPagesTest
:$this->assertSession()->linkExists('SubInSubDirSample::bar', 0, 'Overridden function link is there'); $this->assertSession()->responseContains('A public method'); // the method in question: class SubInSubDirSample extends SampleInSubDir implements SampleInterfaceTwo { /** * {@inheritdoc} */ public function bar() { } // the interface in question interface SampleInterfaceTwo { /** * A public method. */ public function bar(); }
I will investigate what breaks in the core case.
- ๐จ๐ฆCanada Charlie ChX Negyesi ๐Canada
Ah but that was the listing page and the bug report is about the object page. I have updated Formatter::pageFunction to use the override documentation for method, param and return documentation.
- ๐ช๐ธSpain fjgarlin
Code looks good and the tests are still happy (including the new additions).
-
fjgarlin โ
committed c679765b on 2.x authored by
ghost of drupal past โ
Issue #3367886 by ghost of drupal past, fjgarlin: Implementations do not...
-
fjgarlin โ
committed c679765b on 2.x authored by
ghost of drupal past โ
- ๐จ๐ฆCanada Charlie ChX Negyesi ๐Canada
Sorry , wrong branch after commit. It's a different issue. Nevermind it.
Automatically closed - issue fixed for 2 weeks with no activity.